feat: small adjustment to use local server URL like http://minio:9001 #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
please any update on this |
|
Is there any update for this yet please? we really need a way to add custom s3 like contabo object storage etc... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
I performed some validations, mainly for use in Appwrite, in an environment where I am using a local server running an S3-like application, such as Minio Server.
Currently, it is online at http://minio:9001.
For proper functioning, the following requirements are necessary:
Ability to customize the usage protocol, which is currently fixed as https.
Ignore the bucket subdomain and use the bucket as a path-style, where it is currently fixed as a subdomain requirement.
Note
🙏 I took care to maintain existing compatibility and allow the necessary customizations by the user.
Related: