feat(metric): add request attributes and premium geo fields to Metric… - #36
Merged
Conversation
Greptile SummaryThe PR extends event metrics with request attributes and additional premium geolocation fields, with matching event-schema definitions and contract-test expectations.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "feat(metric): increase cookie column siz..." | Re-trigger Greptile |
Comment on lines
+58
to
60
| 'protocol', 'accept', 'acceptLanguage', 'cookie', 'queryKeys', | ||
| // premium geo | ||
| 'city', 'continentCode', 'subdivisions', |
There was a problem hiding this comment.
Event-column contract test breaks
When the test suite runs, testEventColumnsConstant compares Metric::EVENT_COLUMNS with a hard-coded list that omits all ten newly added fields, causing the exact assertSame assertion and CI to fail.
Knowledge Base Used: Usage domain model
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/Usage/Metric.php
Line: 58-60
Comment:
**Event-column contract test breaks**
When the test suite runs, `testEventColumnsConstant` compares `Metric::EVENT_COLUMNS` with a hard-coded list that omits all ten newly added fields, causing the exact `assertSame` assertion and CI to fail.
**Knowledge Base Used:** [Usage domain model](https://app.greptile.com/appwrite/-/custom-context/knowledge-base/utopia-php/usage/-/docs/usage-domain-model.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
abnegate
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… class