Skip to content

comm: remove overhead by .is_dir()#13371

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:comm-is-dir
Open

comm: remove overhead by .is_dir()#13371
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:comm-is-dir

Conversation

@oech3

@oech3 oech3 commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@oech3 oech3 marked this pull request as draft July 12, 2026 14:05
@oech3 oech3 marked this pull request as ready for review July 12, 2026 14:44
@github-actions

github-actions Bot commented Jul 12, 2026 •
edited
Loading

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.

xtqqczze
xtqqczze reviewed Jul 12, 2026
View reviewed changes
Comment thread src/uu/comm/src/comm.rs
@oech3 oech3 force-pushed the comm-is-dir branch 2 times, most recently from 123e4b3 to b6330cf Compare July 13, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@xtqqczze xtqqczze xtqqczze left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oech3 @xtqqczze