uucore: fix time64 build of the process timer - #14496
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Add regression coverage for Timer::arm/wait_or_timeout on an affected time64 target.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This pull request fixes Unix process-timer initialization for time64 targets.
Changes:
- Default-initialize
timespecvalues. - Populate timer expiration fields afterward.
File summaries
| File | Summary |
|---|---|
src/uucore/src/lib/features/process/unix.rs |
Updates timer construction for time64 compatibility; regression coverage is still requested. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| let mut time = libc::itimerspec { | ||
| it_interval: libc::timespec::default(), | ||
| it_value: libc::timespec::default(), | ||
| }; |
Merging this PR will improve performance by 18.85%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | true_consecutive_calls |
350.2 ns | 294.7 ns | +18.85% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing sylvestre:time (df3e017) with main (f604ab9)2
Footnotes
-
50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(51ed5dc) during the generation of this report, so f604ab9 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
|
GNU testsuite comparison: |
No description provided.