feat(df): add thousands separator support #9090

naoNao89 · 2025-10-30T12:07:55Z

Adds GNU-compatible thousands separator formatting to ls, du, and df. Use a leading quote in --block-size to get readable output: --block-size="'1" shows 1,024,000 instead of 1024000.

Respects LC_NUMERIC locale (comma for en_US, period for European locales, none for C/POSIX). Works with environment variables too (LS_BLOCK_SIZE, DU_BLOCK_SIZE, DF_BLOCK_SIZE, etc.).

Core changes in uucore (parse_size.rs, human.rs) handle the parsing and formatting. Each utility integrates it with minimal changes. 12 new integration tests, all existing tests pass.

Closes #9084

github-actions · 2025-10-30T13:00:38Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-10-30T14:39:27Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-07T13:15:13Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

sylvestre · 2025-12-26T00:19:17Z

could you please split this per program in different pr ? thanks
it is harder to review otherwise

sylvestre · 2025-12-26T00:20:06Z

src/uucore/src/lib/features/format/human.rs

+/// - `','` for other locales (default, en_US style)
+fn get_thousands_separator() -> char {
+    // Try to read LC_NUMERIC or LANG environment variable
+    if let Ok(locale) = std::env::var("LC_NUMERIC")


Environment variable reads on every call is inefficient - consider caching the locale information

sylvestre · 2025-12-26T00:20:53Z

src/uucore/src/lib/features/format/human.rs

+
+        // Simple heuristic: European locales use period, others use comma
+        // This covers common cases like de_DE, fr_FR, it_IT, es_ES, nl_NL, etc.
+        if locale.starts_with("de_")


is it?
i don't like this hardcoded list. isn't something in icu to do that?

oki, replace with ICU's FixedDecimalFormatter

github-actions · 2025-12-26T01:12:53Z

GNU testsuite comparison:

Note: The gnu test tests/pr/pr-tests was skipped on 'main' but is now failing.

…s#9090)

github-actions · 2025-12-26T02:51:25Z

GNU testsuite comparison:

Note: The gnu test tests/pr/pr-tests was skipped on 'main' but is now failing.

codspeed-hq · 2025-12-26T03:30:28Z

CodSpeed Performance Report

Merging #9090 will not alter performance

_{Comparing naoNao89:feature/thousands-separator-df (5fd30c4) with main (84e6f03)}

Summary

✅ 130 untouched
⏩ 30 skipped¹

30 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2025-12-26T03:31:56Z

GNU testsuite comparison:

Note: The gnu test tests/pr/pr-tests was skipped on 'main' but is now failing.

github-actions · 2025-12-26T10:55:18Z

GNU testsuite comparison:

Note: The gnu test tests/pr/pr-tests was skipped on 'main' but is now failing.

github-actions · 2025-12-26T11:26:13Z

GNU testsuite comparison:

Note: The gnu test tests/pr/pr-tests was skipped on 'main' but is now failing.

github-actions · 2025-12-26T11:56:01Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

github-actions · 2025-12-26T15:41:38Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

github-actions · 2025-12-27T00:58:04Z

GNU testsuite comparison:

GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?

github-actions · 2025-12-27T11:40:59Z

GNU testsuite comparison:

Note: The gnu test tests/csplit/csplit-heap is now being skipped but was previously passing.
Note: The gnu test tests/cut/cut-huge-range is now being skipped but was previously passing.
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

github-actions · 2025-12-27T20:13:48Z

GNU testsuite comparison:

GNU test failed: tests/cp/cp-mv-enotsup-xattr. tests/cp/cp-mv-enotsup-xattr is passing on 'main'. Maybe you have to rebase?
Note: The gnu test tests/csplit/csplit-io-err was skipped on 'main' but is now failing.

github-actions · 2025-12-27T20:52:46Z

GNU testsuite comparison:

GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?

github-actions · 2025-12-28T13:41:18Z

GNU testsuite comparison:

Congrats! The gnu test tests/tail/assert is no longer failing!

github-actions · 2025-12-28T20:05:33Z

GNU testsuite comparison:

GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?

naoNao89 · 2025-12-28T22:11:19Z

i found that locale_decimal_separator is defined but NOT used anywhere in the current main branch

github-actions · 2025-12-29T02:17:11Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

github-actions · 2025-12-31T01:12:48Z

GNU testsuite comparison:

Congrats! The gnu test tests/tty/tty-eof is no longer failing!

anastygnome · 2025-12-31T13:43:03Z

@naoNao89 there seems to be changes unrelated to the PR, (dd, install), is that a rebase issue?

github-actions · 2026-01-02T00:05:01Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

- Change get_decimal_separator() to accept &Locale instead of Locale - Eliminates problematic .clone() that caused stale thread stack memory - Fixes valgrind failures in tests/sort/sort-stale-thread-mem test - More efficient (avoids unnecessary clone operation)

…gile configurations Addresses PR uutils#9653 review feedback about 'fragile commands' by implementing fail-fast validation in Parser builder pattern. Changes: - Add ParserBuilderError enum with 8 validation error variants - Refactor builder methods to return Result<&mut Self, ParserBuilderError> - Implement comprehensive unit validation (57 valid units including k/m/g/t) - Add cross-validation between builder settings (default_unit vs allow_list) - Detect conflicts (b_byte_count with 'b' unit, '%' with size units) - Update all call sites (sort, du, df, od) to handle new error types - Fix invalid '%' unit in sort's parse_byte_count allow_list Benefits: - Configuration errors detected immediately (not during parsing) - Clear error messages listing invalid/conflicting settings - Maintains backward compatibility through explicit error reporting Files modified: - src/uucore/src/lib/features/parser/parse_size.rs (core implementation) - src/uu/sort/src/sort.rs (error handling + fix invalid '%') - src/uu/du/src/du.rs (error handling) - src/uu/df/src/df.rs (error handling) - src/uu/od/src/od.rs (error handling)

github-actions · 2026-01-02T00:17:58Z

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

anastygnome · 2026-01-02T10:23:53Z

You'll need to use expect to get the conversion working

naoNao89 force-pushed the feature/thousands-separator-df branch 3 times, most recently from 3ce60cf to 48f4bc1 Compare October 30, 2025 12:40

naoNao89 force-pushed the feature/thousands-separator-df branch 2 times, most recently from a8966af to ae09fec Compare October 30, 2025 14:15

naoNao89 closed this by deleting the head repository Nov 6, 2025

naoNao89 reopened this Nov 7, 2025

sylvestre reviewed Dec 26, 2025

View reviewed changes

naoNao89 added a commit to naoNao89/coreutils that referenced this pull request Dec 26, 2025

uucore/human: cache locale and use ICU for thousands separator (uutil…

8b92113

…s#9090)

naoNao89 added a commit to naoNao89/coreutils that referenced this pull request Dec 26, 2025

uucore/human: cache locale and use ICU for thousands separator (uutil…

fb15063

…s#9090)

naoNao89 force-pushed the feature/thousands-separator-df branch from 8b92113 to fb15063 Compare December 26, 2025 02:35

naoNao89 added a commit to naoNao89/coreutils that referenced this pull request Dec 26, 2025

uucore/human: cache locale and use ICU for thousands separator (uutil…

13225ab

…s#9090)

naoNao89 force-pushed the feature/thousands-separator-df branch from fb15063 to 13225ab Compare December 26, 2025 02:35

naoNao89 force-pushed the feature/thousands-separator-df branch from 8aa4f8c to c6cb13e Compare December 26, 2025 10:39

naoNao89 force-pushed the feature/thousands-separator-df branch from 29d396b to e85ae66 Compare December 26, 2025 11:40

naoNao89 force-pushed the feature/thousands-separator-df branch from e85ae66 to 714a5a2 Compare December 26, 2025 15:25

naoNao89 force-pushed the feature/thousands-separator-df branch from 714a5a2 to 3be82c4 Compare December 26, 2025 18:36

naoNao89 force-pushed the feature/thousands-separator-df branch from f8aee0c to faf2e81 Compare December 27, 2025 00:38

naoNao89 force-pushed the feature/thousands-separator-df branch from faf2e81 to eae9883 Compare December 27, 2025 11:18

naoNao89 changed the title ~~feat(ls,du,df): add thousands separator support~~ feat(df): add thousands separator support Dec 27, 2025

naoNao89 force-pushed the feature/thousands-separator-df branch from eae9883 to c46965b Compare December 27, 2025 19:57

naoNao89 force-pushed the feature/thousands-separator-df branch 2 times, most recently from 6be679f to bb7d375 Compare December 27, 2025 20:33

naoNao89 force-pushed the feature/thousands-separator-df branch from bb7d375 to a9b8ee7 Compare December 28, 2025 13:09

naoNao89 force-pushed the feature/thousands-separator-df branch from a9b8ee7 to e7966cf Compare December 28, 2025 19:43

naoNao89 force-pushed the feature/thousands-separator-df branch from e7966cf to ecfd22f Compare December 28, 2025 23:54

naoNao89 marked this pull request as ready for review December 29, 2025 16:05

naoNao89 force-pushed the feature/thousands-separator-df branch from 9216589 to b854560 Compare December 31, 2025 00:33

naoNao89 marked this pull request as draft January 1, 2026 23:08

naoNao89 force-pushed the feature/thousands-separator-df branch 2 times, most recently from 33c107e to b854560 Compare January 1, 2026 23:56

naoNao89 added 2 commits January 2, 2026 00:07

naoNao89 force-pushed the feature/thousands-separator-df branch from b854560 to 5fd30c4 Compare January 2, 2026 00:08

Uh oh!

feat(df): add thousands separator support #9090

Are you sure you want to change the base?

feat(df): add thousands separator support #9090

Uh oh!

Conversation

naoNao89 commented Oct 30, 2025

Uh oh!

github-actions bot commented Oct 30, 2025

Uh oh!

github-actions bot commented Oct 30, 2025

Uh oh!

github-actions bot commented Nov 7, 2025

Uh oh!

sylvestre commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sylvestre Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

sylvestre Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

naoNao89 Dec 26, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

codspeed-hq bot commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #9090 will not alter performance

Summary

Footnotes

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

github-actions bot commented Dec 27, 2025

Uh oh!

github-actions bot commented Dec 27, 2025

Uh oh!

github-actions bot commented Dec 27, 2025

Uh oh!

github-actions bot commented Dec 27, 2025

Uh oh!

github-actions bot commented Dec 28, 2025

Uh oh!

github-actions bot commented Dec 28, 2025

Uh oh!

naoNao89 commented Dec 28, 2025

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

github-actions bot commented Dec 31, 2025

Uh oh!

anastygnome commented Dec 31, 2025

Uh oh!

github-actions bot commented Jan 2, 2026

Uh oh!

github-actions bot commented Jan 2, 2026

Uh oh!

anastygnome commented Jan 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

sylvestre commented Dec 26, 2025 •

edited

Loading

codspeed-hq bot commented Dec 26, 2025 •

edited

Loading