fix(parse_size): Add cross-platform total_physical_memory implementat… #9653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naoNao89
force-pushed
the
feat/cross-platform-percent-buffer-size
branch
from
401a9fe to
8fae6fc
Compare
|
GNU testsuite comparison: |
naoNao89
force-pushed
the
feat/cross-platform-percent-buffer-size
branch
4 times, most recently
from
80fa255 to
34d1ef3
Compare
|
GNU testsuite comparison: |
naoNao89
force-pushed
the
feat/cross-platform-percent-buffer-size
branch
from
34d1ef3 to
f57d398
Compare
|
GNU testsuite comparison: |
Contributor
|
LGTM for FreeBSD and OpenBSD to get "Total physical memory" via |
sylvestre
requested changes
Dec 25, 2025
Contributor
sylvestre
left a comment
sylvestre
left a comment
There was a problem hiding this comment.
this patch has a lot of duplication, could you please have a look? thanks
naoNao89
force-pushed
the
feat/cross-platform-percent-buffer-size
branch
from
f57d398 to
6c0f36a
Compare
|
GNU testsuite comparison: |
…ions - Implements total_physical_memory() for macOS (hw.memsize) - Implements total_physical_memory() for FreeBSD (hw.physmem) - Implements total_physical_memory() for OpenBSD (hw.physmem) - Implements total_physical_memory() for NetBSD (hw.physmem64) - Enables 'sort -S 50%' to work on all BSD-based platforms - Updates tests to include percentage buffer sizes for BSD platforms Fixes uutils#7257
naoNao89
force-pushed
the
feat/cross-platform-percent-buffer-size
branch
from
6c0f36a to
67839ab
Compare
|
GNU testsuite comparison: |
Replace subprocess-based sysctl calls with native libc::sysctl() syscalls for macOS, FreeBSD, OpenBSD, and NetBSD to fix test_buffer_sizes failure in CI environments. The previous implementation spawned sysctl subprocesses which could fail in sandboxed GitHub Actions runners. The native approach is more reliable, performant, and includes subprocess fallback for robustness. Fixes percentage-based buffer size parsing (e.g., sort -S 10%)
naoNao89
force-pushed
the
feat/cross-platform-percent-buffer-size
branch
from
67839ab to
e104905
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
total_physical_memory()for macOS, FreeBSD, OpenBSD, and NetBSD using platform-specificsysctlcommands. Enablessort -S 50%to work on all BSD-based systems.Fixes #7257