Closed
Conversation
# Conflicts: # build.gradle # gradle.properties
Owner
|
Thanks for the ported PR! I'll hold on with the review for when version 1.3 is ready to be ported to 1.21.1, then I'll get back to you. |
Contributor
Author
|
TODO: Default recipe parity with 1.20.1. |
Owner
|
Hello again! As I said in the Skillet PR, I managed to port the 1.3 update to 1.21.1, and a new dev branch is up. However, porting EMI to 1.21.1 was really straightforward, and matches this PR very closely. The only difference is how I resolved the recipe creation in Would you be OK with me just using the translation langs by hand, and closing this PR? I can also try my hand at making the default recipe JSON. |
Contributor
Author
|
100% fine by me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #877
The main difficulty here was translating every tag, but ideally, you won't have to change the tags again.
Check #971 if you want to see the general difference in updating.
EMI has a really good API, so I'd imagine updating wouldn't be too painful, but ultimately, it's your call whether this gets in or not.