Skip to content

Prevent curl_close calls on PHP8.5+#346

Open
miskith wants to merge 1 commit intovimeo:masterfrom
miskith:master
Open

Prevent curl_close calls on PHP8.5+#346
miskith wants to merge 1 commit intovimeo:masterfrom
miskith:master

Conversation

@miskith
Copy link

@miskith miskith commented Feb 11, 2026

curl_close is deprecated in PHP8.5+ so it should not be called.
https://www.php.net/manual/en/function.curl-close.php

Warning

This function has been DEPRECATED as of PHP 8.5.0. Relying on this function is highly discouraged.

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2026

CLA assistant check
All committers have signed the CLA.

@beeradmoore
Copy link

@miskith , have you signed the CLA from above yet?

@miskith
Copy link
Author

miskith commented Mar 3, 2026

Sorry, didnt know there is something to sign. Did so now.

@beeradmoore
Copy link

Thanks!

@aaronm67, would we be able to get this merged in? As OPs link says, curl_close is deprecated as of php8.5. It was doing nothing as of php8.0. As far as I am aware there is no alternative to close the curl connection, but removing it would be doing the same as it was doing in php8.0 at launch so I think it is safe to say this is an ok change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants