fix: add aria-label to password toggle buttons for accessibility#54
Open
DEVOPEOLUWA wants to merge 1 commit intovirtualcell:mainfrom
Open
fix: add aria-label to password toggle buttons for accessibility#54DEVOPEOLUWA wants to merge 1 commit intovirtualcell:mainfrom
DEVOPEOLUWA wants to merge 1 commit intovirtualcell:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 1 — Missing aria-label on password toggle buttons
Problem: Three icon-only elements that toggle password visibility (using Eye/EyeOff icons) had no accessible name. Screen readers announced them as just "button", making it impossible for visually impaired users to understand what the buttons do.
Issue 3 — Silent error swallowing in search
Problem: The catch block in handleSearch silently cleared results with no user feedback. If the API was down or a network error occurred, users saw nothing — no error message, no indication anything went wrong. The search simply appeared to return zero results.
Fix: Added an error state variable, set a user-facing error message ("Failed to search biomodels. Please try again.") in the catch block, clear it at the start of each new search, and display it as a red Alert banner above the results section.