Skip to content

fix(core): set open state false when switching to no entry#337

Merged
antfu merged 1 commit into
vitejs:mainfrom
JianJroh:fix/dock-panel-open-state-on-close
May 14, 2026
Merged

fix(core): set open state false when switching to no entry#337
antfu merged 1 commit into
vitejs:mainfrom
JianJroh:fix/dock-panel-open-state-on-close

Conversation

@JianJroh
Copy link
Copy Markdown
Contributor

@JianJroh JianJroh commented May 11, 2026

Description

Before

After opening any dock entry once, the dock stayed fully expanded forever — moving the mouse away or waiting past inactiveTimeout no longer collapsed it to the small minimized dot. Only pressing ESC could restore the auto-minimize behavior. The stuck state also persisted across page reloads.

After

Closing a panel via toggle re-click, click-outside, or ESC all behave the same: the dock collapses to the minimized dot after inactiveTimeout once the mouse leaves.

Test plan

  • Toggle-close an entry → dock minimizes after 3s
  • Click outside to close → dock minimizes after 3s
  • ESC to close → dock minimizes after 3s

@netlify
Copy link
Copy Markdown

netlify Bot commented May 11, 2026

Deploy Preview for devfra canceled.

Name Link
🔨 Latest commit e914759
🔍 Latest deploy log https://app.netlify.com/projects/devfra/deploys/6a02c4060dd6b300086e4b2a

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 11, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/devtools@337
npm i https://pkg.pr.new/@vitejs/devtools-kit@337
npm i https://pkg.pr.new/@vitejs/devtools-rolldown@337
npm i https://pkg.pr.new/@vitejs/devtools-self-inspect@337

commit: 0fefd00

@JianJroh JianJroh force-pushed the fix/dock-panel-open-state-on-close branch from 595bf6a to e914759 Compare May 12, 2026 06:09
@JianJroh JianJroh force-pushed the fix/dock-panel-open-state-on-close branch from e914759 to 0fefd00 Compare May 13, 2026 02:53
@antfu antfu merged commit 0259bcf into vitejs:main May 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants