refactor: extract devframe to standalone repo + bump to v0.2.0#341
Merged
Conversation
Devframe now lives at github.com/devframes/devframe; this monorepo consumes it as `devframe` from npm via `catalog:deps` and keeps a git submodule at `devframe/` (tag-pinned, never a branch) as a checked-in reference. `scripts/sync.ts` (run via `pnpm sync`) aligns the submodule with the catalog version and is hooked into `postinstall` so fresh clones init automatically. Drops 43 `devframe/*` path aliases, turbo tasks, vitest projects, and the merged docs section.
commit: |
antfu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Devframe now lives at github.com/devframes/devframe and is published independently; this monorepo deletes its 200+ embedded source files and consumes
devframeas an npm dependency viacatalog:deps(initially pinned to^0.2.0). A git submodule atdevframe/mirrors the source at the catalog-pinned tag (never a branch) for browsing and upstream contributions, managed by a newscripts/sync.ts(pnpm sync) that aligns the submodule with the catalog, validates the tag exists before bumping, and runs inpostinstallso fresh clones init automatically. Six dependents (kit,core,rolldown,self-inspect,vite,docs) flip fromworkspace:*tocatalog:deps, the 43devframe/*path aliases plus turbo tasks / vitest projects / merged docs section all disappear, andAGENTS.mdis trimmed of devframe-internal architecture/principles (now upstream). CI getssubmodules: recursiveon checkout;pnpm install,pnpm build,pnpm typecheck,pnpm test,pnpm lint, andpnpm docs:buildare all green against devframe v0.2.0.Linked Issues
Additional context
Reviewer focus: (1) the
scripts/sync.tsdesign — especially that it validates upstream tag existence before mutatingpnpm-workspace.yamland refuses to leave the submodule at a non-tag commit; (2) the catalog cleanup inpnpm-workspace.yaml(dropped 11 entries previously used only by devframe —@modelcontextprotocol/sdk,@valibot/to-json-schema,ansis,immer,launch-editor,ohash,open,valibot,whenexpr,preact,@preact/preset-vite); (3) the docs cross-link retargeting indocs/kit/streaming.mdfrom/devframe/...tohttps://devfra.me/....