fix(docs): build workspace packages before docs#344
Merged
Conversation
Twoslash resolves `@vitejs/devtools*` imports via the package's `types` field, which points at `dist/index.d.ts`. Without a prior `pnpm build`, those files don't exist and `vitepress build` fails with TS2307.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pnpm docs:buildwas failing withTS2307: Cannot find module '@vitejs/devtools'because twoslash resolves the package'stypesfield (dist/index.d.ts) — which doesn't exist until the workspace packages have been built. Chainingpnpm build(turbo-cached, so it's a no-op when nothing changed) before the docs build makespnpm docs:buildself-sufficient from a fresh clone or after cleaningdist/.Linked Issues
Additional context