Skip to content

feat: use carets for rolldown versions#1216

Open
AviVahl wants to merge 1 commit into
vitejs:mainfrom
AviVahl:rolldown-1.0.0
Open

feat: use carets for rolldown versions#1216
AviVahl wants to merge 1 commit into
vitejs:mainfrom
AviVahl:rolldown-1.0.0

Conversation

@AviVahl
Copy link
Copy Markdown

@AviVahl AviVahl commented May 9, 2026 •
edited
Loading

Description

  • changed all pluginutils requests to carets now that rolldown is at stable 1.0.0 (and to match other deps)

@AviVahl
Copy link
Copy Markdown
Author

AviVahl commented May 9, 2026

FYI @hi-ogawa @sapphi-red

ArnaudBarre
ArnaudBarre reviewed May 10, 2026
View reviewed changes
Comment thread pnpm-lock.yaml Outdated
'@rolldown/binding-win32-arm64-msvc': 1.0.0
'@rolldown/binding-win32-x64-msvc': 1.0.0

rolldown@1.0.0-rc.17:
Copy link
Copy Markdown
Member

@ArnaudBarre ArnaudBarre May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For info there is still this version in the lockfile (but it was already duplicated)

Copy link
Copy Markdown
Author

@AviVahl AviVahl May 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that one seems to come from the dependency on vite itself.

Once vite releases the new version (with rolldown@1.0.0), and this repository upgrades, there will be a single rolldown version in node_modules.

@hi-ogawa
Copy link
Copy Markdown
Contributor

hi-ogawa commented May 11, 2026

Sorry, I missed this one. I merged the renovate PR #1218 but it has exact pin 1.0.0, but should be relaxed like you did. Can you update the PR?

@AviVahl AviVahl changed the title feat: update rolldown to 1.0.0 feat: use carets for rolldown versions May 11, 2026
@AviVahl
Copy link
Copy Markdown
Author

AviVahl commented May 11, 2026

Sorry, I missed this one. I merged the renovate PR #1218 but it has exact pin 1.0.0, but should be relaxed like you did. Can you update the PR?

done. rebased to latest main, adding the carets to relax the range.
also updated title and description to reflex the more limited change (now that main is already updated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArnaudBarre ArnaudBarre ArnaudBarre left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AviVahl @hi-ogawa @ArnaudBarre