Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+38
to
+42
| - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1 | ||
| with: | ||
| repository: rolldown/rolldown | ||
| path: rolldown | ||
| ref: ${{ steps.upstream-versions.outputs.ROLLDOWN_HASH }} |
Check notice
Code scanning / zizmor
credential persistence through GitHub Actions artifacts Note
The rolldown directory is not a git submodule — it's an external repo cloned by the CI clone action. The deny workflow had `submodules: true` which was a no-op. Replace it with an explicit rolldown checkout at the pinned hash from .upstream-versions.json.
The setup-rust action resolves cargo-deny@latest to 0.18.4 which cannot parse CVSS 4.0 scores in the advisory database (RUSTSEC-2026-0009). Pin to 0.18.9 which includes the fix from EmbarkStudios/cargo-deny#805.
Add missing allowed licenses (BSD-2-Clause, BSL-1.0, bzip2-1.0.6, CC0-1.0, CDLA-Permissive-2.0, MIT-0, Zlib) to match rolldown's config. Allow git sources from voidzero-dev, reubeno, polachok, branchseer orgs. Exclude unlicensed first-party crates from checks and ignore upstream advisory IDs from rolldown dependencies.
fengmk2
changed the title
The graph exclude already handles unlicensed first-party crates, so this setting is unnecessary.
Brooooooklyn
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cargo deny checkpasses locally with exit code 0