chore: add bump-vite-task skill for Claude Code#1093
chore: add bump-vite-task skill for Claude Code#1093branchseer wants to merge 2 commits intomainfrom
Conversation
Documents the best practices for bumping the vite-task git dependency, including handling breaking changes, updating snap tests, and CI verification.
✅ Deploy Preview for viteplus-preview canceled.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26098ccce7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ### 3. Verify compilation | ||
|
|
||
| - Run `cargo check` to ensure the new vite-task compiles without errors. |
There was a problem hiding this comment.
cargo check
In a fresh checkout this step fails before the bump can even be validated: the workspace root hardcodes many path dependencies under ./rolldown (Cargo.toml), and CI compensates by running .github/actions/clone before cargo check (.github/workflows/ci.yml, .github/actions/clone/action.yml). Because that prerequisite is only buried in the final Notes section, an agent following the numbered workflow will hit a spurious failure at step 3 unless it already knows to clone the upstream trees first.
Useful? React with 👍 / 👎.
| 4. Check all three platforms (Linux, Mac, Windows) since they may have slightly different snap test coverage. | ||
| 5. Watch for trailing newline issues - ensure snap files end consistently. | ||
|
|
||
| Snap test files are at `packages/cli/snap-tests/*/snap.txt`. |
There was a problem hiding this comment.
snap-tests-global in the snapshot update path
The snapshot instructions currently point only at packages/cli/snap-tests/*/snap.txt, but packages/cli/package.json defines snap-test as snap-test-local && snap-test-global, and the repo has a separate packages/cli/snap-tests-global/ tree. A vite-task bump that changes global vp help or error output will still fail the CLI E2E job even if the agent updates every file in the path listed here.
Useful? React with 👍 / 👎.
2 participants
Summary
Test plan