Skip to content

fix(migrate): auto-remove allowSyntheticDefaultImports: false from tsconfig.json#1153

Merged
graphite-app[bot] merged 1 commit intomainfrom
auto-remove-allowSyntheticDefaultImports-false
Mar 27, 2026
Merged

fix(migrate): auto-remove allowSyntheticDefaultImports: false from tsconfig.json#1153
graphite-app[bot] merged 1 commit intomainfrom
auto-remove-allowSyntheticDefaultImports-false

Conversation

@fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Mar 26, 2026

Same deprecation reason as esModuleInterop: false — tsgolint no longer
supports these options set to false. Generalize the removal into a
reusable removeDeprecatedTsconfigFalseOption function and apply it
to both options during migration.

See #1145

@fengmk2 fengmk2 self-assigned this Mar 26, 2026
Copy link
Member Author

fengmk2 commented Mar 26, 2026


How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 force-pushed the auto-remove-esModuleInterop-false-on-migrate branch from 2f47f2d to e94c039 Compare March 26, 2026 14:10
@fengmk2 fengmk2 force-pushed the auto-remove-allowSyntheticDefaultImports-false branch from 8a893f2 to 8dff00e Compare March 26, 2026 14:10
@fengmk2 fengmk2 marked this pull request as ready for review March 27, 2026 02:01
@fengmk2 fengmk2 force-pushed the auto-remove-allowSyntheticDefaultImports-false branch from 8dff00e to 608f3d3 Compare March 27, 2026 05:44
@fengmk2 fengmk2 force-pushed the auto-remove-esModuleInterop-false-on-migrate branch from e94c039 to 14e9dc4 Compare March 27, 2026 05:44
@fengmk2 fengmk2 force-pushed the auto-remove-allowSyntheticDefaultImports-false branch from 608f3d3 to 2044f98 Compare March 27, 2026 06:07
@fengmk2 fengmk2 force-pushed the auto-remove-esModuleInterop-false-on-migrate branch from 14e9dc4 to fbc6e84 Compare March 27, 2026 06:07
@fengmk2 fengmk2 added the test: e2e Auto run e2e tests label Mar 27, 2026
@fengmk2 fengmk2 force-pushed the auto-remove-allowSyntheticDefaultImports-false branch from 2044f98 to e1816ee Compare March 27, 2026 06:15
@fengmk2 fengmk2 force-pushed the auto-remove-esModuleInterop-false-on-migrate branch 2 times, most recently from e3bece6 to da92617 Compare March 27, 2026 06:25
@fengmk2 fengmk2 force-pushed the auto-remove-allowSyntheticDefaultImports-false branch 2 times, most recently from b602550 to 6a0ba69 Compare March 27, 2026 06:27
@fengmk2 fengmk2 force-pushed the auto-remove-esModuleInterop-false-on-migrate branch from da92617 to 30d9c30 Compare March 27, 2026 06:27
@fengmk2 fengmk2 force-pushed the auto-remove-allowSyntheticDefaultImports-false branch from 6a0ba69 to ecbe383 Compare March 27, 2026 06:37
@fengmk2 fengmk2 force-pushed the auto-remove-esModuleInterop-false-on-migrate branch from 30d9c30 to 013eea9 Compare March 27, 2026 06:37
@fengmk2 fengmk2 force-pushed the auto-remove-allowSyntheticDefaultImports-false branch from ecbe383 to 5f9b8dd Compare March 27, 2026 07:18
@graphite-app
Copy link

graphite-app bot commented Mar 27, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the auto-remove-esModuleInterop-false-on-migrate branch from 013eea9 to 3fd5160 Compare March 27, 2026 11:46
graphite-app bot pushed a commit that referenced this pull request Mar 27, 2026
…config.json (#1153)

Same deprecation reason as esModuleInterop: false — tsgolint no longer
supports these options set to false. Generalize the removal into a
reusable `removeDeprecatedTsconfigFalseOption` function and apply it
to both options during migration.

See #1145
@graphite-app graphite-app bot force-pushed the auto-remove-allowSyntheticDefaultImports-false branch from 5f9b8dd to 4547752 Compare March 27, 2026 11:46
@graphite-app graphite-app bot force-pushed the auto-remove-esModuleInterop-false-on-migrate branch from 3fd5160 to 9965461 Compare March 27, 2026 11:50
graphite-app bot pushed a commit that referenced this pull request Mar 27, 2026
…config.json (#1153)

Same deprecation reason as esModuleInterop: false — tsgolint no longer
supports these options set to false. Generalize the removal into a
reusable `removeDeprecatedTsconfigFalseOption` function and apply it
to both options during migration.

See #1145
@graphite-app graphite-app bot force-pushed the auto-remove-allowSyntheticDefaultImports-false branch from 4547752 to 710de88 Compare March 27, 2026 11:50
…config.json (#1153)

Same deprecation reason as esModuleInterop: false — tsgolint no longer
supports these options set to false. Generalize the removal into a
reusable `removeDeprecatedTsconfigFalseOption` function and apply it
to both options during migration.

See #1145
@fengmk2 fengmk2 force-pushed the auto-remove-allowSyntheticDefaultImports-false branch from 710de88 to 273ba39 Compare March 27, 2026 12:08
@fengmk2 fengmk2 force-pushed the auto-remove-esModuleInterop-false-on-migrate branch from 9965461 to 749ef1d Compare March 27, 2026 12:08
Base automatically changed from auto-remove-esModuleInterop-false-on-migrate to main March 27, 2026 12:19
@graphite-app graphite-app bot merged commit 273ba39 into main Mar 27, 2026
73 of 92 checks passed
@graphite-app graphite-app bot deleted the auto-remove-allowSyntheticDefaultImports-false branch March 27, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test: e2e Auto run e2e tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants