fix(snapshots): scope registry teardown signal#2115
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
force-pushed
the
fix-snap-registry-teardown
branch
from
9b411d2 to
cfbc122
Compare
This was referenced Jul 9, 2026
fengmk2
force-pushed
the
fix-snap-registry-teardown
branch
from
8397ec3 to
cfbc122
Compare
The local-registry teardown sent SIGTERM to both the server process and its process group (kill -TERM <pid> -<pid>). On the GitHub-hosted ubuntu-latest PTY runs that process-group signal leaked past the case boundary and reached the Actions runner agent, which reported "runner received a shutdown signal" and cancelled the job. Confirmed via a bpftrace probe on signal:signal_generate: no suite process ever sends a SIGINT, so the runner itself was doing the cancelling in response to the stray group SIGTERM. Scope the SIGTERM to the direct child; the server's own handler still removes its throwaway caches and the force-kill fallback still guarantees teardown.
#2126 (vite-task bump) resolved the ConPTY block on Namespace's Windows runners, so move cli-snapshot-test-windows from GitHub-hosted windows-latest to namespace-profile-windows-4c-8g. The comment keeps the prior Session-0 caveat as a revert path.
fengmk2
force-pushed
the
fix-snap-registry-teardown
branch
from
cfbc122 to
52ce2b9
Compare
wan9chi
approved these changes
Jul 10, 2026
Merge activity
|
graphite-app Bot
pushed a commit
that referenced
this pull request
Jul 10, 2026
Migrates all 149 legacy `vp migrate` snap-test cases (144 from `snap-tests-global`, 5 from `snap-tests`) to the PTY snapshot suite under `crates/vite_cli_snapshots`, and removes the legacy dirs. Part of #2078. Adds `redact.rs` rules for the managed-toolchain versions that appear in `vp migrate` output and bump on release: the completion banner (`Migrated . to Vite+ <version>`), the version-change table's managed rows (vite-plus, vite, vitest, `@vitest/*`, keeping the installed-source column), and the bundled vitest pins written into catalogs/overrides. The `not-supported-vite6`/`vitest3` cases stub `node_modules/<pkg>/package.json` instead of running a network `vp install`, so migrate reads the unsupported version offline. Stacked on #2115 (local-registry teardown signal fix), which the Linux snapshot job needs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local-registry teardown sent SIGTERM to both the server process and
its process group (kill -TERM -). On the GitHub-hosted
ubuntu-latest PTY runs that process-group signal leaked past the case
boundary and reached the Actions runner agent, which reported "runner
received a shutdown signal" and cancelled the job. Confirmed via a
bpftrace probe on signal:signal_generate: no suite process ever sends a
SIGINT, so the runner itself was doing the cancelling in response to the
stray group SIGTERM. Scope the SIGTERM to the direct child; the server's
own handler still removes its throwaway caches and the force-kill fallback
still guarantees teardown.