test(snapshots): migrate the last blocked snap tests to the PTY suite#2143
Merged
Conversation
This was referenced Jul 10, 2026
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
14 tasks
wan9chi
approved these changes
Jul 10, 2026
Merge activity
|
…#2143) Migrates the final 10 legacy snap tests, emptying both legacy trees (`packages/cli/snap-tests`, `packages/cli/snap-tests-global`). Runner additions that unblock them: - Step env values expand `${NAME}`: `${workspace}` resolves to the step's working directory, any other name to the case env. This expresses the shell forms `VP_HOME="$(pwd)/home"` and `PATH="$(pwd)/bin:$PATH"` used by `command-env-setup-external-vp`, `npm-global-install-custom-prefix-on-path`, and `shim-corepack-enable-install-directory`. - Programs a case creates under its own root (shims from an isolated `vp env setup`) count as case-owned for resolution, and a per-case `link-node-modules = true` exposes the run-root `node_modules` as the workspace parent-dir `node_modules` like the legacy layout, so `bin-oxlint-wrapper`/`bin-oxfmt-wrapper` address `../node_modules/vite-plus/bin/*` verbatim. - The `./`-prefix program join no longer leaks a `/./` component into recorded shim targets, and an empty step cwd no longer leaks a trailing separator into `${workspace}`. Hermeticity fixes over the legacy versions: `shim-npm-downloads-uncached-package-manager-version` sets `seed-runtime = false` (its `rm` of a pinned runtime must not reach the shared seed through the symlink) and pins `.node-version 22.11.0` instead of inheriting the environment default; `command-env-setup-external-vp` drops `VP_BYPASS` (the hermetic PATH has no system node); the custom-prefix case asserts the npm bin as a symlink, which the legacy `test -f` followed silently. `fingerprint-ignore-test` and `vitest-browser-mode` stay disabled on every platform as in the legacy suite; their fixtures carry the converted steps and record no snapshot until re-enabled. The legacy CI jobs (`cli-snap-test` matrix, retry script, Renovate ignorePaths for the trees) are removed here too, and the legacy runner exits cleanly when a tree is absent from a fresh checkout, so local `pnpm test` keeps working. Deleting the legacy runner and migrator tooling under `packages/tools` can follow separately. Closes #2116.
graphite-app
Bot
force-pushed
the
migrate-command-pm-snap-tests
branch
from
efd0c6b to
98cca64
Compare
graphite-app
Bot
force-pushed
the
migrate-blocked-snap-tests
branch
from
d83fa3b to
e208eef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the final 10 legacy snap tests, emptying both legacy trees (
packages/cli/snap-tests,packages/cli/snap-tests-global).Runner additions that unblock them:
${NAME}:${workspace}resolves to the step's working directory, any other name to the case env. This expresses the shell formsVP_HOME="$(pwd)/home"andPATH="$(pwd)/bin:$PATH"used bycommand-env-setup-external-vp,npm-global-install-custom-prefix-on-path, andshim-corepack-enable-install-directory.vp env setup) count as case-owned for resolution, and a per-caselink-node-modules = trueexposes the run-rootnode_modulesas the workspace parent-dirnode_moduleslike the legacy layout, sobin-oxlint-wrapper/bin-oxfmt-wrapperaddress../node_modules/vite-plus/bin/*verbatim../-prefix program join no longer leaks a/./component into recorded shim targets, and an empty step cwd no longer leaks a trailing separator into${workspace}.Hermeticity fixes over the legacy versions:
shim-npm-downloads-uncached-package-manager-versionsetsseed-runtime = false(itsrmof a pinned runtime must not reach the shared seed through the symlink) and pins.node-version 22.11.0instead of inheriting the environment default;command-env-setup-external-vpdropsVP_BYPASS(the hermetic PATH has no system node); the custom-prefix case asserts the npm bin as a symlink, which the legacytest -ffollowed silently.fingerprint-ignore-testandvitest-browser-modestay disabled on every platform as in the legacy suite; their fixtures carry the converted steps and record no snapshot until re-enabled.The legacy CI jobs (
cli-snap-testmatrix, retry script, Renovate ignorePaths for the trees) are removed here too, and the legacy runner exits cleanly when a tree is absent from a fresh checkout, so localpnpm testkeeps working. Deleting the legacy runner and migrator tooling underpackages/toolscan follow separately.Closes #2116.