fix(env): detect default fish config path in vp env doctor#920
Open
mst-mkt wants to merge 2 commits intovoidzero-dev:mainfrom
Open
fix(env): detect default fish config path in vp env doctor#920mst-mkt wants to merge 2 commits intovoidzero-dev:mainfrom
vp env doctor#920mst-mkt wants to merge 2 commits intovoidzero-dev:mainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
mst-mkt
force-pushed
the
fix/doctor-default-fish-config
branch
from
d9ba01b to
c179e5e
Compare
Contributor
Author
|
I've rebased. Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on @fengmk2's comment in #892.
Summary
vp env doctordid not detect fish shell config at~/.config/fish/conf.d/vite-plus.fish.This PR adds that check so doctor correctly reports IDE integration for fish users.
Changes
~/.config/fish/conf.d/vite-plus.fishincheck_profile_filesbefore returningNonetest_check_profile_files_default_fish_config,test_check_profile_files_no_fish_config)Note
This will likely conflict with #892 since both touch
check_profile_files. Conflict resolution will be needed after whichever merges first.