feat(cli): add shell completion support#974
Open
nekomoyi wants to merge 5 commits intovoidzero-dev:mainfrom
Open
feat(cli): add shell completion support#974nekomoyi wants to merge 5 commits intovoidzero-dev:mainfrom
nekomoyi wants to merge 5 commits intovoidzero-dev:mainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Contributor
Author
|
Looking into the CI failure. |
fengmk2
reviewed
Mar 18, 2026
| [target.'cfg(target_os = "linux")'] | ||
| rustflags = ["--cfg", "tokio_unstable", "-C", "link-args=-Wl,--warn-unresolved-symbols"] | ||
|
|
||
| # Increase stack size on Windows to avoid stack overflow |
Member
There was a problem hiding this comment.
@nekomoyi Is it caused by the newly introduced clap_complete?
Contributor
Author
There was a problem hiding this comment.
Yes, this is the root cause.However, I believe this is an underlying issue of clap on Windows, and the recursive generate process of clap_complete exposed it.
clap-rs/clap#5134
|
There is a bug in the |
Member
|
@nekomoyi can you rebase and fix conflicts? |
…ive paths Fix mixed path separators in env files on Windows - Before: $HOME/.vite-plus\bin (mixed) - After: $HOME/.vite-plus/bin (consistent) Simplify completion generation with loop-based approach
…dows - Increase stack size to 8MB on Windows - Set RUST_MIN_STACK to 8MB in CI test jobs Cargo test default (2MB) are insufficient for deep recursion in clap_complete::generate(). This causes stack overflow when generating shell completion scripts during tests.
nekomoyi
force-pushed
the
feat/cli-completion
branch
from
0d02ce0 to
9fb37ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements shell completion for the vp CLI.
Changes
Completion scripts for bash, zsh, fish, and PowerShell are generated in
~/.vite-plus/completion/when runningvp env setup, and automatically sourced in the respective env files.Fixes
Fixed mixed path separators in env files on Windows to use forward slashes consistently for
$HOME-relative pathsIncreased stack size to 8MB to handle deep recursion in
clap_complete::generate()which exceeds Windows' default stack size.Closes #950