Merged
Conversation
The `command` field in `UserTaskConfig` is now required instead of optional. Tasks in the `tasks` map must always specify their command explicitly rather than falling back to a package.json script with the same name. Package.json scripts not in the tasks map continue to work as standalone tasks. - Change `command` from `Option<Box<str>>` to `Box<str>` in `UserTaskConfig` - Remove `CommandConflict` and `NoCommand` error variants since they no longer apply - Simplify `ResolvedTaskConfig::resolve()` to no longer accept `package_json_script` parameter - Update all test fixtures to include explicit `command` fields - Regenerate TypeScript type definitions (`run-config.ts`) - Update documentation in CLAUDE.md https://claude.ai/code/session_01LMFoqFGF6abfJ3WuSeEoRk
A task in the `tasks` map with the same name as a package.json script now produces a `ScriptConflict` error, since both define a command and the intent is ambiguous. The error message guides users to either remove the script from package.json or rename the task. Adds a `script-conflict` plan snapshot test fixture to verify the error. https://claude.ai/code/session_01LMFoqFGF6abfJ3WuSeEoRk
fengmk2
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change makes the
commandfield mandatory in task configurations withinvite-task.json. Previously, tasks could omit the command and fall back to a corresponding script defined inpackage.json. This change simplifies the configuration model by requiring explicit command definitions.Key Changes
commandfield required: ChangedUserTaskConfig.commandfromOption<Box<str>>toBox<str>, making it a required field during deserializationpackage.jsonscripts when a task command was omittedResolveTaskConfigError::CommandConflictandResolveTaskConfigError::NoCommandas they are no longer neededResolvedTaskConfig::resolve()to only accept user config and package directory, removing thepackage_json_scriptparametervite-task.jsoninstead of relying onpackage.jsonscriptscommandis now requiredImplementation Details
vite-task.jsonmust now include an explicitcommandfieldhttps://claude.ai/code/session_01LMFoqFGF6abfJ3WuSeEoRk