Skip to content

fix: increase e2e test step timeout on Windows to fix flaky CI #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
branchseer merged 2 commits into from
Mar 15, 2026
Merged

fix: increase e2e test step timeout on Windows to fix flaky CI #252

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a21e0ed
fix: increase e2e test step timeout on Windows to fix flaky CI
claude Mar 15, 2026
f0178f4
style: fix rustfmt formatting for conditional timeout
claude Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions crates/vite_task_bin/tests/e2e_snapshots/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@ use vite_path::{AbsolutePath, AbsolutePathBuf, RelativePathBuf};
use vite_str::Str;
use vite_workspace::find_workspace_root;

/// Timeout for each step in e2e tests
const STEP_TIMEOUT: Duration = Duration::from_secs(20);
/// Timeout for each step in e2e tests.
/// Windows CI needs a longer timeout due to Git Bash startup overhead and slower I/O.
const STEP_TIMEOUT: Duration =
if cfg!(windows) { Duration::from_secs(60) } else { Duration::from_secs(20) };

/// Screen size for the PTY terminal. Large enough to avoid line wrapping.
const SCREEN_SIZE: ScreenSize = ScreenSize { rows: 500, cols: 500 };
Expand Down
Loading