perf(fspy): use sparse Windows shared memory#525
Closed
wan9chi wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 9, 2026
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 9, 2026
42992a3 to
fcc530f
Compare
2ee5a9c to
a7e9506
Compare
fcc530f to
5d1ba2f
Compare
a7e9506 to
41e4c55
Compare
5d1ba2f to
51f4393
Compare
41e4c55 to
4190b5e
Compare
4190b5e to
b38ebb3
Compare
51f4393 to
adc5221
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b38ebb3d06
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
adc5221 to
39b502d
Compare
b38ebb3 to
daf99c3
Compare
39b502d to
29bdc15
Compare
29bdc15 to
9bcba8e
Compare
a9b45dc to
0de39b7
Compare
9bcba8e to
62be316
Compare
6df5e61 to
91edb14
Compare
62be316 to
283d922
Compare
91edb14 to
fd848aa
Compare
283d922 to
6691051
Compare
fd848aa to
c21af71
Compare
6691051 to
033dbe6
Compare
c21af71 to
7047470
Compare
033dbe6 to
079c1af
Compare
7047470 to
eeceb2e
Compare
2fb905b to
83d2b75
Compare
eeceb2e to
52690ed
Compare
83d2b75 to
f3a5ac6
Compare
52690ed to
8bb2b67
Compare
f3a5ac6 to
e7205e0
Compare
2f24313 to
bc90566
Compare
e7205e0 to
1161f5b
Compare
bc90566 to
38adc89
Compare
1161f5b to
ddfb5f3
Compare
38adc89 to
dafca75
Compare
ddfb5f3 to
13bda67
Compare
Co-authored-by: GPT-5.6 <gpt-5.6@openai.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
dafca75 to
cc20cc0
Compare
13bda67 to
45c8d2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
Avoid allocating a fully backed 4 GiB temporary file for every tracked task on Windows.
Background
The parity backend deliberately retains the previous file-backed resource model. Marking that file sparse allows the logical mapping to remain 4 GiB while physical allocation follows the small prefix actually used by fspy records.
Changes
FSCTL_SET_SPARSEbefore extending the file.