Skip to content

use rstest for some test cleanups #7813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a10y merged 2 commits into from
May 6, 2026
+161 −464
Merged

use rstest for some test cleanups #7813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d87b1b
rstest
a10y May 6, 2026
b9fa536
more
a10y May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 9 additions & 36 deletions encodings/zigzag/src/compress.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ where

#[cfg(test)]
mod test {
use rstest::rstest;
use vortex_array::IntoArray;
use vortex_array::LEGACY_SESSION;
use vortex_array::VortexSessionExecute;
Expand All @@ -85,44 +86,16 @@ mod test {
use super::*;
use crate::ZigZag;

#[test]
fn test_compress_i8() {
#[rstest]
#[case::i8(PrimitiveArray::from_iter(-100_i8..100))]
#[case::i16(PrimitiveArray::from_iter(-100_i16..100))]
#[case::i32(PrimitiveArray::from_iter(-100_i32..100))]
#[case::i64(PrimitiveArray::from_iter(-100_i64..100))]
fn test_compress(#[case] input: PrimitiveArray) {
let mut ctx = LEGACY_SESSION.create_execution_ctx();
let compressed = zigzag_encode(PrimitiveArray::from_iter(-100_i8..100).as_view())
.unwrap()
.into_array();
let compressed = zigzag_encode(input.as_view()).unwrap().into_array();
assert!(compressed.is::<ZigZag>());
let decompressed = compressed.execute::<PrimitiveArray>(&mut ctx).unwrap();
assert_arrays_eq!(decompressed, PrimitiveArray::from_iter(-100_i8..100));
}
#[test]
fn test_compress_i16() {
let mut ctx = LEGACY_SESSION.create_execution_ctx();
let compressed = zigzag_encode(PrimitiveArray::from_iter(-100_i16..100).as_view())
.unwrap()
.into_array();
assert!(compressed.is::<ZigZag>());
let decompressed = compressed.execute::<PrimitiveArray>(&mut ctx).unwrap();
assert_arrays_eq!(decompressed, PrimitiveArray::from_iter(-100_i16..100));
}
#[test]
fn test_compress_i32() {
let mut ctx = LEGACY_SESSION.create_execution_ctx();
let compressed = zigzag_encode(PrimitiveArray::from_iter(-100_i32..100).as_view())
.unwrap()
.into_array();
assert!(compressed.is::<ZigZag>());
let decompressed = compressed.execute::<PrimitiveArray>(&mut ctx).unwrap();
assert_arrays_eq!(decompressed, PrimitiveArray::from_iter(-100_i32..100));
}
#[test]
fn test_compress_i64() {
let mut ctx = LEGACY_SESSION.create_execution_ctx();
let compressed = zigzag_encode(PrimitiveArray::from_iter(-100_i64..100).as_view())
.unwrap()
.into_array();
assert!(compressed.is::<ZigZag>());
let decompressed = compressed.execute::<PrimitiveArray>(&mut ctx).unwrap();
assert_arrays_eq!(decompressed, PrimitiveArray::from_iter(-100_i64..100));
assert_arrays_eq!(decompressed, input);
}
}
Loading
Loading