Use AllNonDistinct in assert_arrays_eq and implement it for variant types#8546
Conversation
28495bc to
e89702f
Compare
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
224.4 µs | 259.5 µs | -13.52% |
| ❌ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
271.4 µs | 306.6 µs | -11.48% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
205.6 µs | 168.9 µs | +21.76% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing assert_arrays_eq_allnondistinct (828662a) with develop (f41dc23)
Footnotes
-
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
7a2926b to
5946841
Compare
…ypes Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
5946841 to
1796890
Compare
AllNonDistinct is exactly the semantics we want, it should be faster and in case
of failure we run the slow method to produce precise error message