Skip to content

Use AllNonDistinct in assert_arrays_eq and implement it for variant types#8546

Merged
robert3005 merged 6 commits into
developfrom
assert_arrays_eq_allnondistinct
Jun 24, 2026
Merged

Use AllNonDistinct in assert_arrays_eq and implement it for variant types#8546
robert3005 merged 6 commits into
developfrom
assert_arrays_eq_allnondistinct

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

AllNonDistinct is exactly the semantics we want, it should be faster and in case
of failure we run the slow method to produce precise error message

@robert3005 robert3005 requested a review from a team June 22, 2026 23:29
@robert3005 robert3005 force-pushed the assert_arrays_eq_allnondistinct branch from 28495bc to e89702f Compare June 22, 2026 23:30
@codspeed-hq

codspeed-hq Bot commented Jun 22, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 1582 untouched benchmarks
⏩ 4 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_canonical_into[(100, 100)] 224.4 µs 259.5 µs -13.52%
Simulation chunked_varbinview_into_canonical[(100, 100)] 271.4 µs 306.6 µs -11.48%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 205.6 µs 168.9 µs +21.76%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing assert_arrays_eq_allnondistinct (828662a) with develop (f41dc23)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@robert3005 robert3005 added the changelog/chore A trivial change label Jun 23, 2026
@robert3005 robert3005 force-pushed the assert_arrays_eq_allnondistinct branch 2 times, most recently from 7a2926b to 5946841 Compare June 23, 2026 12:29
@robert3005 robert3005 enabled auto-merge (squash) June 23, 2026 13:07
@robert3005 robert3005 requested review from AdamGS and onursatici June 23, 2026 13:16
Comment thread encodings/parquet-variant/src/compute/allnondistinct.rs Outdated
…ypes

Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 force-pushed the assert_arrays_eq_allnondistinct branch from 5946841 to 1796890 Compare June 23, 2026 21:30
Comment thread encodings/parquet-variant/src/compute/allnondistinct.rs
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 merged commit d0d400c into develop Jun 24, 2026
69 of 71 checks passed
@robert3005 robert3005 deleted the assert_arrays_eq_allnondistinct branch June 24, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants