Repository navigation
RowFn framework and machinery - #9319
Closed
connortsui20 wants to merge 3 commits into
Closed
connortsui20 wants to merge 3 commits into
connortsui20 wants to merge 3 commits into
Conversation
Introduce typed row execution with self-contained kernel arguments and explicit execution contracts. Validate decoded lengths once per batch while preserving specialized mixed-constant loops. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Cover RowFn executor overhead and strict validity policies with focused microbenchmarks. Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Merging this PR will improve performance by 26.84%
Performance Changes
Tip Curious why this is faster? Comment Comparing 
Footnotes
|
connortsui20
force-pushed
the
ct/row-fn-api
branch
from
August 10, 2026 01:55
c626a33 to
84837ad
Compare
connortsui20
marked this pull request as ready for review
August 10, 2026 02:58
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
joseph-isaacs
left a comment
joseph-isaacs
left a comment
Contributor
There was a problem hiding this comment.
i'll continue tomorrow.
i would be interested in keeping the internals private so we can iterate
| #[derive(Clone, Copy)] | ||
| pub struct KernelArgs<'a> { | ||
| /// The input arrays for this kernel invocation. | ||
| pub arrays: &'a [ArrayRef], |
Contributor
There was a problem hiding this comment.
does this struct not exist?
| } | ||
|
|
||
| /// One batch of inputs and the metadata needed before its row kernel runs. | ||
| pub struct Batch { |
Contributor
There was a problem hiding this comment.
does it need to be pub?
| Dense, | ||
|
|
||
| /// Evaluate all rows, retrying only valid rows if a deferred error is raised. | ||
| DenseWithRetry, |
Contributor
There was a problem hiding this comment.
shall we remove this initially?
| #[derive(Clone, Copy, Debug, PartialEq, Eq)] | ||
| pub enum RowPolicy { | ||
| /// Evaluate all rows and mask the result. | ||
| Dense, |
Contributor
There was a problem hiding this comment.
another option is zipping output with rows and combing valid and fail?
| pub trait RowFn: 'static + Sized + Clone + Send + Sync { | ||
| /// Options for this function, if any. Use [`EmptyOptions`](crate::scalar_fn::EmptyOptions) | ||
| /// for none. | ||
| type Options: 'static + Send + Sync + Clone + Debug + Display + PartialEq + Eq + Hash; |
Contributor
There was a problem hiding this comment.
should we give this a name and use it with scalar fn and here
| /// - The output **must not** introduce a null where every input is valid. | ||
| /// | ||
| /// The framework skips this hook for nullary functions. | ||
| fn reduce_encoded( |
| ArgColumnKind<T>, | ||
| ); | ||
|
|
||
| enum ArgColumnKind<T: InputElement> { |
Contributor
There was a problem hiding this comment.
we should use this throughout all of vortex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking Issues: #9129, #9130
Adds the
RowFnAPI, its private batch executor, and focused executor benchmarks.TODO