refactor(array): allocate execution outputs through context - #9671
Conversation
Merging this PR will degrade performance by 5.16%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | mul_u64_nonnull_neon |
15.2 µs | 20.9 µs | -27.21% |
| ❌ | WallTime | mul_i64_nonnull_neon |
17.1 µs | 20.1 µs | -15.02% |
| ❌ | WallTime | multiply_shapes_neon[(16384, PerRowPerRow)] |
17.1 µs | 20.1 µs | -14.68% |
| ❌ | WallTime | dict_canonicalize_gt_u8_avx2[16000000] |
7 ms | 8.2 ms | -14.37% |
| ❌ | Simulation | take_search[(0.005, 0.05)] |
19.8 µs | 22.8 µs | -13.37% |
| ❌ | Simulation | take_search[(0.01, 0.05)] |
20.5 µs | 23.6 µs | -13.14% |
| ❌ | WallTime | dict_canonicalize_gt_u8_avx2[1000000] |
427.7 µs | 481.1 µs | -11.1% |
| ❌ | Simulation | take_search[(0.005, 0.1)] |
26.1 µs | 29.1 µs | -10.31% |
| ⚡ | WallTime | arrow_checked_add_u32_neon[16384] |
20.4 µs | 13.4 µs | +52.9% |
| ⚡ | WallTime | filtered_owned_i64_avx512[OneNullInEight] |
26.3 µs | 22.1 µs | +18.76% |
| ⚡ | Simulation | allocate_drop_arrow[0] |
456.9 ns | 402.7 ns | +13.45% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ngates/buffer-allocator-execution (ed0df23) with develop (ad925fd)2
Footnotes
-
218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
develop(ed4d347) during the generation of this report, so ad925fd was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
f8000e4 to
9a8b653
Compare
6931802 to
ed2fbe7
Compare
ed2fbe7 to
3c868b7
Compare
09d740d to
3e127b9
Compare
8d4cbfb to
92397b9
Compare
92397b9 to
da81af8
Compare
da81af8 to
6210f3b
Compare
375111f to
af6234b
Compare
af6234b to
aa6801b
Compare
903c310 to
2898fb0
Compare
20a5f31 to
2af2152
Compare
2377f06 to
a8ffb77
Compare
a8ffb77 to
929ff0a
Compare
e099a82 to
c8eae21
Compare
bfb9ddf to
0264ccd
Compare
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
0264ccd to
d3fcfb0
Compare
Signed-off-by: Nicholas Gates <nick@nickgates.com>
robert3005
left a comment
There was a problem hiding this comment.
Is there some follow up for other crates? I think you want to forbid in the codebase the non allocator taking methods which you can do via clippy lint
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
|
On workspace-wide enforcement: #9672 was the original follow-up, but its targeted regex checker was the wrong mechanism and was closed. Clippy |
Summary
Allocate execution outputs through the execution context.
Changes