Skip to content

ci: reject implicit engine buffer allocation - #9672

Draft
gatesn wants to merge 3 commits into
ngates/buffer-allocator-executionfrom
ngates/buffer-allocator-enforce
Draft

ci: reject implicit engine buffer allocation#9672
gatesn wants to merge 3 commits into
ngates/buffer-allocator-executionfrom
ngates/buffer-allocator-enforce

Conversation

@gatesn

@gatesn gatesn commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Reject implicit buffer allocation in engine code.

Changes

  • Add a check for implicit constructors in allocator-aware paths.
  • Run the check in Rust lint CI.

@gatesn gatesn mentioned this pull request Aug 27, 2026
5 tasks
@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch from 5b79473 to 2f3e584 Compare August 27, 2026 19:38
@codspeed-hq

codspeed-hq Bot commented Aug 27, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 27.52%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 2 regressed benchmarks
✅ 2092 untouched benchmarks
⏩ 206 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime arrow_checked_add_u32_neon[16384] 12.2 µs 20.4 µs -40.29%
WallTime words_gather_scalar_avx2[65536] 8.2 µs 9.4 µs -12.01%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ngates/buffer-allocator-enforce (c18fde8) with ngates/buffer-allocator-execution (a8ffb77)

Open in CodSpeed

Footnotes

  1. 206 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch from 2f3e584 to d578a0a Compare August 27, 2026 20:42
@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch 2 times, most recently from 5be81fc to 13894b2 Compare August 27, 2026 21:38
@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch 2 times, most recently from 36176c7 to 24c4ffc Compare August 28, 2026 14:56
@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch from 24c4ffc to 7837e58 Compare August 28, 2026 16:06
@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch from 7837e58 to 092912f Compare August 28, 2026 17:03
@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch from 092912f to e5fea5f Compare August 28, 2026 17:35
@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch 2 times, most recently from 0aa2518 to 5014df5 Compare August 28, 2026 18:22
@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch from 5014df5 to 1bd0883 Compare August 28, 2026 18:24
@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch from 1bd0883 to 1edde31 Compare August 28, 2026 20:41
@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch from 1edde31 to b9c94d9 Compare August 28, 2026 20:50
@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch 3 times, most recently from eedc0f8 to fc0be30 Compare August 29, 2026 02:00
@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch from fc0be30 to b09ec24 Compare August 29, 2026 02:45
@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch from b09ec24 to 3e98c72 Compare August 29, 2026 03:17
@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch from 3e98c72 to 7976d61 Compare August 31, 2026 13:49
@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch 2 times, most recently from 61fbe5d to f77d428 Compare September 2, 2026 14:47
@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch from f77d428 to d7e9401 Compare September 2, 2026 15:35
@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch from d7e9401 to 5300014 Compare September 2, 2026 16:10
@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch 2 times, most recently from 44b997f to 5549077 Compare September 2, 2026 16:59
@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch from 5549077 to 9dffd89 Compare September 2, 2026 17:02
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn
gatesn force-pushed the ngates/buffer-allocator-enforce branch from 9dffd89 to c18fde8 Compare September 2, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/deprecation A change that introduces a series of API deprecations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant