Skip to content

Prepare benchmark-specific data formats - #9685

Open
palaska wants to merge 2 commits into
developfrom
bp/fix-data-gen-format-preparation
Open

palaska wants to merge 2 commits into
developfrom
bp/fix-data-gen-format-preparation

Conversation

@palaska

@palaska palaska commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

data-gen now calls each benchmark's prepare_format hook after standard conversions. This creates benchmark-specific formats through vx-bench prepare-data.

Validation:

  • cargo +nightly fmt --all --check
  • cargo clippy -p vortex-bench --all-targets --all-features -- -D warnings

Agent: Codex.

Signed-off-by: Baris Palaska <barispalaska@gmail.com>
@palaska palaska added the changelog/fix A bug fix label Aug 28, 2026
@codspeed

codspeed Bot commented Aug 28, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by 52.75%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
✅ 2186 untouched benchmarks
⏩ 218 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ WallTime arrow_checked_add_u32_neon[16384] 20.4 µs 13.4 µs +52.75%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing bp/fix-data-gen-format-preparation (1873df3) with develop (bffdca1)

Open in CodSpeed

Footnotes

  1. 218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@palaska
palaska enabled auto-merge (squash) August 28, 2026 10:32
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been marked as stale because it has been open for 14 days with no activity. Please comment or remove the stale label if you wish to keep it active, otherwise it will be closed in 7 days

@github-actions github-actions Bot added the stale This PR is stale and will be auto-closed soon label Sep 26, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix stale This PR is stale and will be auto-closed soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant