feat(cc-digital-channel): add-new-package #586
Conversation
| @@ -0,0 +1,118 @@ | |||
| import {defineConfig} from 'vite'; | |||
There was a problem hiding this comment.
We have webpack setted up for all the packages, can we reuse that?
| }, | ||
| fallback: { | ||
| ...baseConfig.resolve?.fallback, | ||
| 'process/browser': require.resolve('process/browser.js'), |
There was a problem hiding this comment.
These can be put in the base config itself, both alias and the fallback.
| 'react-dom': 'react-dom', | ||
| '@webex/cc-store': '@webex/cc-store', | ||
| '@momentum-ui/react-collaboration': '@momentum-ui/react-collaboration', | ||
| '@momentum-ui/web-components': '@momentum-ui/web-components', |
There was a problem hiding this comment.
I dont think this is requried, as we are not using this anywhere
| @@ -1,7 +1,18 @@ | |||
| import {StationLogin} from '@webex/cc-station-login'; | |||
There was a problem hiding this comment.
Also update the wc entry file. I know its not used but atleast we should be expsoing everything for uniformity, also when we fix it in the future we should have the reference for this digital channel in there
| "@momentum-ui/core": "19.16.0", | ||
| "@momentum-ui/icons": "8.28.5", | ||
| "@momentum-ui/react-collaboration": "26.197.0", | ||
| "@momentum-ui/tokens": "1.7.1", | ||
| "@momentum-ui/utils": "6.2.15", | ||
| "@momentum-ui/web-components": "^2.23.35", |
There was a problem hiding this comment.
All these are dependency of @momentum-ui/react-collaboration and are alrady present in the node_modules, Why are we mentinoing these again here?
| @@ -0,0 +1,13 @@ | |||
| // Declare custom HTML elements used by the Webex Engage components | |||
There was a problem hiding this comment.
Since we wont require md-theme, we can get rid of this file as well
| import {mockTask, mockCC} from '@webex/test-fixtures'; | ||
|
|
||
| // Mock mobx-react-lite to make observer work properly in tests | ||
| jest.mock('mobx-react-lite', () => ({ |
There was a problem hiding this comment.
Can we avoid this, we wanna make sure the store changes are being recevied by the widget
| // The fact that we get here means: | ||
| // 1. Real @webex-engage/wxengage-conversations loaded successfully | ||
| // 2. Real @momentum-ui/web-components loaded successfully | ||
| // 3. No runtime errors occurred | ||
| // 4. All dependencies were satisfied with minimal mocking | ||
| }); |
There was a problem hiding this comment.
Can we remove these comments
| it('should successfully load and initialize real Engage component without errors', () => { | ||
| // This test proves we can test with the real Engage component | ||
| expect(() => { | ||
| render(<DigitalChannels {...mockProps} />); |
There was a problem hiding this comment.
Can we check something in the dom to ensure the widget is loaded
|
|
||
| // Everything else uses real components: | ||
| // ✅ Real @webex-engage/wxengage-conversations | ||
| // ✅ Real @momentum-ui/web-components |
There was a problem hiding this comment.
too many AI comments
2 participants
COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7419
Vidcast Link: https://app.vidcast.io/share/b8c6a7dc-9b23-4f39-8c3c-06ec0ae84763
This pull request addresses
This PR is to consume engage npm packag and expose the digital widget as part of cc-widgets
< DESCRIBE THE CONTEXT OF THE ISSUE >
consumed "@webex-engage/wxengage-conversations": "^1.0.2", added yarnrc t o have cisco repository config and token.
by making the following changes
Created a new package @webex/cc-digital-channels and consumed "@webex-engage/wxengage-conversations": "^1.0.2"
< DESCRIBE YOUR CHANGES >
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.