-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: use new URL instead of url.parse #5637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
alexander-akait
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with this change, feel free to merge when CI will be green, also we have url.parse in our webpack-dev-middleware, make sense to improve this there too for the next major release
f5d7016 to
7e9fc7c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #5637 +/- ##
==========================================
+ Coverage 83.56% 83.68% +0.11%
==========================================
Files 11 11
Lines 1947 1955 +8
Branches 723 724 +1
==========================================
+ Hits 1627 1636 +9
+ Misses 287 286 -1
Partials 33 33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // If the header does not have a scheme, prepend // so URL can parse it | ||
| const parseUrl = new URL( | ||
| /^(.+:)?\/\//.test(header) ? header : `//${header}`, | ||
| "http://localhost/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only for a fallback.
|
Thanks |

Summary
An important change, IPv6 hostnames now return with square brackets (
[]) (for new URL()), so they need to be formatted foripaddrto correctly validate whether it’s an IPv6 URL. Additionally, the hostname also needs to be formatted in the IPv6 case, because right now, when an IPv6 hostname is passed inhost, users are not including the square brackets. We could change this behavior, what do you think?Also, it seems this will make retrieving the hostname faster.
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?