Repository navigation
Conversation
…ng crawl, not from the crawl workflow (crawlconfig), as certain settings, like exclusions, may have changed on the workflow since the crawl was run. While this could be desirable in some cases, it is probably more accurate to run the QA with exact settings of the crawl, especially around scope, exclusions, limits, etc...
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out the QA Runs were getting the crawl config from the current workflow, rather than previously run crawl.
Certain settings like exclusions, may have changed on the workflow since the crawl was run, so really it should be running on the exact same config (especially raw crawler config) that was used originally. Setting that we want to allow modifying should be set explicitly for the QA run.
Note: On the other hand, this does allow customizing QA run by modifying the workflow a workaround, eg. could force QA on certain pages by setting it on the workflow first, or changing the crawler channel to use for QA, but this is sort of a confusing hack that we plan to address later by allowing matching regex and page limits for QA.