Skip to content

QA Run: Get Config from Crawl, not from Workflow - #3828

Open
ikreymer wants to merge 1 commit into
mainfrom
qa-config-from-crawl
Open

ikreymer wants to merge 1 commit into
mainfrom
qa-config-from-crawl

Conversation

@ikreymer

Copy link
Copy Markdown
Member

It turns out the QA Runs were getting the crawl config from the current workflow, rather than previously run crawl.

Certain settings like exclusions, may have changed on the workflow since the crawl was run, so really it should be running on the exact same config (especially raw crawler config) that was used originally. Setting that we want to allow modifying should be set explicitly for the QA run.

Note: On the other hand, this does allow customizing QA run by modifying the workflow a workaround, eg. could force QA on certain pages by setting it on the workflow first, or changing the crawler channel to use for QA, but this is sort of a confusing hack that we plan to address later by allowing matching regex and page limits for QA.

…ng crawl, not from the crawl workflow (crawlconfig),

as certain settings, like exclusions, may have changed on the workflow since the crawl was run.
While this could be desirable in some cases, it is probably more accurate to run the QA with exact settings
of the crawl, especially around scope, exclusions, limits, etc...
@ikreymer
ikreymer requested a review from tw4l November 20, 2026 18:11

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant