Expose when setNavigationRoot is called on RootPresenter#7586
Expose when setNavigationRoot is called on RootPresenter#7586zzorba wants to merge 1 commit intowix:masterfrom
Conversation
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Not stale, still very relevant for anyone wanting to implement the new splash screen behavior from Android 12 |
|
Just wondering if this might be able to get in soon. It's needed to support the new Android 11 style splash screen, which has been out for some time now. |
|
Another vote for having this merged in. Support for Android 12 splashscreens would be awesome, and this is currently blocking that effort. |
|
Throwing my vote in here as well. I've applied these changes via patch-package and they are working to allow to me to use the new SplashScreen API on Android. |
| } | ||
|
|
||
| public void setRoot(ViewController appearingRoot, ViewController<?> disappearingRoot, Options defaultOptions, CommandListener listener, ReactInstanceManager reactInstanceManager) { | ||
| setRootCalled = true; |
There was a problem hiding this comment.
It would be better to move this into animateSetRootAndReportSuccess, right before the listener.onSuccess calls. And you'll need 2 lines of it, one in each block.
4 participants
This change exposes when
setNavigationRootis called by the javascript application on the RootPresenter class.This is needed to implement the new Android 12 style splash screen (discussion here: #7363), so that the screen can persist until the application is ready to show real content.