Cgo wrapper hardening: bounds, validation, missing stubs#39
Draft
JeremiahM37 wants to merge 4 commits intowolfSSL:masterfrom
Draft
Cgo wrapper hardening: bounds, validation, missing stubs#39JeremiahM37 wants to merge 4 commits intowolfSSL:masterfrom
JeremiahM37 wants to merge 4 commits intowolfSSL:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes F-3021, F-1866, F-2546, F-1872, F-1875, F-2550, F-2553, F-2551, F-3023
Summary:
len(inPlain)+tagso oversized caller buffers don't leave garbage between cipher and tag.math.MaxInt32before theC.intcast inWolfSSL_read/write, curve25519 make_pub/make_priv,BIO_new_mem_buf, and X509 buffer wrappers (BIO can wrap to -1, OpenSSL'sstrlensentinel).iter <= 0inWc_PBKDF2and require exactlyCURVE25519_KEYSIZEon curve25519 export/shared_secret outputs.