Fix ML-KEM templates in tests#183
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the ML-KEM-related test templates to explicitly request keys that the tests can read back (via CKA_VALUE) for comparison and re-import scenarios.
Changes:
- Make generated ML-KEM private keys explicitly non-sensitive and extractable in the key-pair generation helper.
- Make encapsulated/decapsulated secret keys explicitly non-sensitive so tests can read
CKA_VALUEand compare shared secrets. - Add clarifying comment explaining why private keys are generated as extractable/non-sensitive in tests.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aidangarske
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.