Fix attributes in tests#184
Merged
Merged
Conversation
LinuxJedi
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the PKCS#11 verify-recover negative test to disable the correct key capability attribute, ensuring the test exercises C_VerifyRecoverInit behavior based on CKA_VERIFY_RECOVER rather than CKA_VERIFY.
Changes:
- Update the RSA public key template in
test_verify_recover_op_not_supportedto setCKA_VERIFY_RECOVER = CK_FALSE(instead ofCKA_VERIFY = CK_FALSE). - Rename the local attribute template variable and adjust the related test messages to match the new attribute being tested.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LinuxJedi
force-pushed
the
verify-recover-test
branch
from
ef19ece to
ce2dc6a
Compare
Out-of-order merges caused some attribute issues.
LinuxJedi
force-pushed
the
verify-recover-test
branch
from
ce2dc6a to
0722e98
Compare
LinuxJedi
changed the title
dgarske
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.