Fix TLS 1.2 PRF KDFs to pass a MAC algorithm id to wc_PRF_TLS - #24
Open
aidangarske wants to merge 1 commit into
Open
Fix TLS 1.2 PRF KDFs to pass a MAC algorithm id to wc_PRF_TLS#24aidangarske wants to merge 1 commit into
aidangarske wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
value to wc_PRF_TLS, which expects a wc_MACAlgorithm id.
wrong hash — HASH_TYPE_E on builds without SHA-512, and a wrong SHA-512 digest
on builds with it.
enum, used at both wc_PRF_TLS call sites.
rather than silently promoting to SHA-256.
wrong enum, and adds test_tls12_prf checking output against a
wc_PRF_TLS(sha256_mac) reference.
M33MU emulator: the TLS 1.2 PRF key-derivation test caught it since sha 512 wasnt enabled