Skip to content

Deduplication and type checking - #1159

Merged
ejohnstown merged 5 commits into
wolfSSL:masterfrom
stenslae:followup-review-findings
Sep 2, 2026
Merged

Deduplication and type checking#1159
ejohnstown merged 5 commits into
wolfSSL:masterfrom
stenslae:followup-review-findings

Conversation

@stenslae

@stenslae stenslae commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Added authorized_key type checking to extracts the embedded key type directly from the SSH
    wire-format blob rather than using wolfSSH_QueryKey().
  • Added a makeKey function pointer to CompositeTradOps.
  • Deduplicated ECDSA Encoding
  • Added WOLFSSH_MLDSA_MAX_PUB_KEY_SZ macro.
  • Switched to dynamically allocating MlDsaKey and large public key buffers when WOLFSSH_SMALL_STACK
    is defined.
  • Auto-gates ML-DSA composites behind WOLFSSH_NO_MLDSA_COMPOSITES when the required
    underlying algorithms are disabled in wolfCrypt.
  • Ensured EOF appending on all POSIX systems in SFTP, failed short Windows writes,
    and consolidated the Windows SFTP flag matrix testing.
  • Stopped wolfsshd option parsing when a Windows argv conversion fails.
  • Added test coverage.

@stenslae stenslae self-assigned this Aug 11, 2026
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Aug 11, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1159

Scan targets checked: wolfssh-bugs, wolfssh-src

Findings: 5
5 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

Comment thread src/internal.c
Comment thread src/ossh.c
Comment thread apps/wolfsshd/test/test_configuration.c Outdated
Comment thread apps/wolfsshd/auth.c Outdated
Comment thread apps/wolfsshd/test/test_configuration.c
stenslae
stenslae commented Aug 11, 2026
View reviewed changes
Comment thread apps/wolfsshd/test/test_configuration.c
stenslae
stenslae commented Aug 11, 2026
View reviewed changes
Comment thread apps/wolfsshd/auth.c Outdated
stenslae
stenslae commented Aug 11, 2026
View reviewed changes
Comment thread apps/wolfsshd/test/test_configuration.c Outdated
stenslae
stenslae commented Aug 11, 2026
View reviewed changes
Comment thread src/ossh.c
stenslae
stenslae commented Aug 11, 2026
View reviewed changes
Comment thread src/internal.c
@stenslae
stenslae force-pushed the followup-review-findings branch from fc3c6e8 to 8000746 Compare August 12, 2026 16:13
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Aug 12, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1159

Scan targets checked: wolfssh-bugs, wolfssh-src

Findings: 7
7 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

Comment thread apps/wolfsshd/auth.c Outdated
Comment thread tests/unit.c
Comment thread src/keygen.c
Comment thread apps/wolfsshd/test/test_configuration.c
Comment thread apps/wolfsshd/test/test_configuration.c Outdated
Comment thread apps/wolfsshd/test/test_configuration.c
@stenslae
stenslae force-pushed the followup-review-findings branch from 8000746 to 818f77b Compare August 12, 2026 21:02
stenslae
stenslae commented Aug 12, 2026
View reviewed changes
Comment thread apps/wolfsshd/auth.c Outdated
stenslae
stenslae commented Aug 12, 2026
View reviewed changes
Comment thread tests/unit.c
stenslae
stenslae commented Aug 12, 2026
View reviewed changes
Comment thread apps/wolfsshd/test/test_configuration.c
stenslae
stenslae commented Aug 12, 2026
View reviewed changes
Comment thread src/keygen.c
stenslae
stenslae commented Aug 12, 2026
View reviewed changes
Comment thread apps/wolfsshd/test/test_configuration.c Outdated
stenslae
stenslae commented Aug 12, 2026
View reviewed changes
Comment thread apps/wolfsshd/test/test_configuration.c
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Aug 12, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1159

Scan targets checked: wolfssh-bugs, wolfssh-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

Comment thread apps/wolfsshd/test/test_configuration.c
stenslae
stenslae commented Aug 12, 2026
View reviewed changes
Comment thread apps/wolfsshd/test/test_configuration.c
@stenslae
stenslae force-pushed the followup-review-findings branch from 818f77b to 6f506d2 Compare August 12, 2026 22:48
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Aug 12, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1159

Scan targets checked: wolfssh-bugs, wolfssh-src

Findings: 4
4 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

Comment thread apps/wolfsshd/test/test_configuration.c Outdated
Comment thread src/internal.c
Comment thread apps/wolfsshd/test/test_configuration.c Outdated
Comment thread apps/wolfsshd/auth.c
@stenslae
stenslae force-pushed the followup-review-findings branch from 6f506d2 to 0e54524 Compare August 31, 2026 18:06
stenslae
stenslae commented Aug 31, 2026
View reviewed changes
Comment thread apps/wolfsshd/auth.c
stenslae
stenslae commented Aug 31, 2026
View reviewed changes
Comment thread apps/wolfsshd/test/test_configuration.c Outdated
stenslae
stenslae commented Aug 31, 2026
View reviewed changes
Comment thread src/internal.c
stenslae
stenslae commented Aug 31, 2026
View reviewed changes
Comment thread apps/wolfsshd/test/test_configuration.c Outdated
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Aug 31, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1159

Scan targets checked: wolfssh-bugs
Failed targets: wolfssh-src

⚠️ Review incomplete — one or more scan targets failed before findings could be produced. See the Fenrir PR review detail page for logs.

wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Aug 31, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1159

Scan targets checked: none
Failed targets: wolfssh-bugs, wolfssh-src

⚠️ Review incomplete — one or more scan targets failed before findings could be produced. See the Fenrir PR review detail page for logs.

wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Aug 31, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1159

Scan targets checked: wolfssh-bugs, wolfssh-src

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

@stenslae stenslae assigned wolfSSL-Bot and unassigned stenslae Aug 31, 2026
ejohnstown
ejohnstown requested changes Sep 1, 2026
View reviewed changes
Comment thread wolfssh/internal.h Outdated
Comment thread ChangeLog.md Outdated
Comment thread configure.ac Outdated
@ejohnstown ejohnstown assigned stenslae and unassigned wolfSSL-Bot Sep 1, 2026
Emma Stensland added 4 commits September 2, 2026 11:56
Emma Stensland
wolfsshd: Check authorized_keys types against the key blob
ce2e114
Emma Stensland
internal: Share one bounded ECDSA r/s mpint encoder
82e7bc5
Emma Stensland
internal: Refactor and gate ML-DSA composite key handling
48764ae 
Gates ML-DSA composites behind WOLFSSH_NO_MLDSA_COMPOSITES.
Deduplicates key handling and uses heap allocation for
composite buffers when compiling for small stacks.
Emma Stensland
wolfsshd: Stop option parsing when a Windows argv conversion fails
6b77490
@stenslae
stenslae force-pushed the followup-review-findings branch from 0e54524 to 2cbdb58 Compare September 2, 2026 18:48
Emma Stensland
wolfsftp: Improve POSIX and Windows write/append handling
a48116b 
Ensures EOF appending on all POSIX systems and fails short writes on Windows.
Consolidates the Windows SFTP flag matrix testing with shared helpers.
@stenslae
stenslae force-pushed the followup-review-findings branch from 2cbdb58 to a48116b Compare September 2, 2026 18:56
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Sep 2, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1159

Scan targets checked: wolfssh-bugs, wolfssh-src

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

@ejohnstown
ejohnstown self-requested a review September 2, 2026 21:16
@ejohnstown
ejohnstown merged commit ea530fe into wolfSSL:master Sep 2, 2026
171 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left review comments
@ejohnstown ejohnstown ejohnstown approved these changes

Assignees

@stenslae stenslae

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stenslae @ejohnstown @wolfSSL-Fenrir-bot @wolfSSL-Bot