Repository navigation
sftp: refuse dir REMOVE and replacing RENAME - #1333
Open
ejohnstown wants to merge 1 commit into
Open
ejohnstown wants to merge 1 commit into
ejohnstown wants to merge 1 commit into
Conversation
SSH_FXP_REMOVE does not take directories and SSH_FXP_RENAME fails on an existing newpath (draft-ietf-secsh-filexfer-02 6.5). The non-Windows handlers now check the target with an lstat first, and REMOVE unlinks. A regular file renames by linkat() and unlink(), which refuses an existing name atomically; anything else checks then calls rename(). - configure: probe for linkat() - port.h: WUNLINK on POSIX, WLINK as linkat() when configure finds it - FatFs, Nucleus: only "/" and "/." stand in for the root - regress: test both against files, directories, symlinks and a read-only directory Issue: F-15535, F-15536
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1333
Scan targets checked: wolfssh-src, wolfssh-bugs
Not reviewed (no scan target covers them): configure.ac
Coverage: 3 of 3 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
ejohnstown
force-pushed
the
sftp-rm-mv
branch
from
October 20, 2026 21:48
8e17212 to
09f2a18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSH_FXP_REMOVE now refuses a directory and SSH_FXP_RENAME refuses an
existing newpath, per draft-ietf-secsh-filexfer-02 6.5. Windows already
behaved this way.
check then rename(); configure probes for linkat()
Issue: F-15535, F-15536