tls13.c fixes + Add configure and CMake options for WOLF_CRYPTO_CB_RSA_PAD.#10428
Open
kareem-wolfssl wants to merge 5 commits intowolfSSL:masterfrom
Open
tls13.c fixes + Add configure and CMake options for WOLF_CRYPTO_CB_RSA_PAD.#10428kareem-wolfssl wants to merge 5 commits intowolfSSL:masterfrom
kareem-wolfssl wants to merge 5 commits intowolfSSL:masterfrom
Conversation
…g them. Thanks to Cal Page for the report.
…L object until the function has finished. This avoids ssl->certReqCtx being set when the function returns an error. Thanks to Cal Page for the report.
Thanks to Cal Page for the report.
This was referenced May 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds safety/validation fixes in TLS 1.3 paths and introduces build-system toggles for RSA-padding-aware crypto callbacks (WOLF_CRYPTO_CB_RSA_PAD).
Changes:
- Add additional bounds checks in
Tls13_Exporter()and improve null-safety inwolfSSL_get_cipher_name_by_hash(). - Defer
CertReqCtxallocation inDoTls13CertificateRequest()until after further message validation. - Add
--enable-cryptocb-rsa-pad(autotools) andWOLFSSL_CRYPTOCB_RSA_PAD(CMake) options to defineWOLF_CRYPTO_CB_RSA_PAD.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/tls13.c |
Adds input/bounds validation and adjusts CertificateRequest context handling to reduce premature allocation; adds null-guards. |
configure.ac |
Adds autotools configure flag to enable WOLF_CRYPTO_CB_RSA_PAD. |
cmake/options.h.in |
Adds header-template entries for WOLF_CRYPTO_CB_RSA_PAD. |
CMakeLists.txt |
Adds CMake option and compile definition for WOLF_CRYPTO_CB_RSA_PAD with dependency checking. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
My tests of src/tls13.c ran ok against the patch. (issue-tls13-codex-review). I did not test the autogen/configure issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10271 #10313
Testing
Built in tests
Checklist