Integrate Translation framework #25089

kean · 2025-12-22T22:35:37Z

Description

Closes CMM-745: On-device translation for posts.

Testing instructions

Open Reader and find a post in a locale different from your current locale and supported by the Translation framework
Tap "More" and verify that the Translate button is available
Tap "Translate" and verify that the spinner is shown in the navigation items
Verify that on the first translation, the system prompts you to download the required translations
Verify that after translation is successful, both the title and the content are translated. The content should preserve its HTML structure and tags

Recording

ScreenRecording_12-22-2025.16-58-08_1.MP4

kean · 2025-12-22T22:38:15Z

WordPress/Classes/ViewRelated/Reader/Detail/ReaderDetailViewController.swift

+        }
+        translationAvailabilityTask?.cancel()
+        translationAvailabilityTask = Task { @MainActor in
+            self.isTranslationAvailable = await self.checkIsTranslationAvailable()


It creates a little bit of a race condition, but in practice, it's extremely fast so it should not matter.

wpmobilebot · 2025-12-22T22:49:30Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	`30286`
	Version	`PR #25089`
	Bundle ID	`org.wordpress.alpha`
	Commit	`14cb490`
	Installation URL	5l5l47t494ndg

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2025-12-22T22:49:33Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	`30286`
	Version	`PR #25089`
	Bundle ID	`com.jetpack.alpha`
	Commit	`14cb490`
	Installation URL	749q3uftjths0

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

crazytonyli · 2026-01-05T08:42:23Z

WordPress/Classes/ViewRelated/Reader/Detail/ReaderDetailViewController.swift

+    }
+
+    private lazy var _translationViewModel: Any = {
+        guard #available(iOS 26, *) else { return {} }


Not sure how I feel about this pattern... I guess it's fine, since the else block is dead code because the caller only runs on iOS 26+. But maybe there is another better (in terms of readability) way to code this?

crazytonyli · 2026-01-05T08:46:33Z

Modules/Sources/WordPressIntelligence/UseCases/TranslationViewModel.swift

+
+        // Use continuation to wait for translation result
+        return try await withCheckedThrowingContinuation { continuation in
+            self.continuation = continuation


It seems a bit risky to hold the continuation instances at the class level, instead of locally in the function.

crazytonyli · 2026-01-05T09:49:26Z

I couldn't get the translation to work. I can see the UI from the Translation framework, but after selecting languages, the app shows an "Unable to translate" error message. There are 100+ repeating error messages in Xcode console:

Got response from extension with error: Error Domain=TranslationErrorDomain Code=14 "(null)"
Connection interrupted, finishing translation with error Error Domain=TranslationErrorDomain Code=14 "(null)"

kean · 2026-01-05T16:53:20Z

I couldn't get the translation to work. I can see the UI from the Translation framework, but after selecting languages, the app shows an "Unable to translate" error message. There are 100+ repeating error messages in Xcode console:

I forgot to mention that it requires a physical device. Have you tried on a physical one or a sim?

crazytonyli · 2026-01-05T19:34:12Z

@kean Yes, I used my iPhone 16. I also downloaded the Chinese and English languages in the Translate app, which I don't think is necessary, but just in case.

…it never restarts the translation if already started

kean · 2026-01-05T23:17:08Z

I've tested a few other scenarios and found and fixed some issues:

Added isTranslating flag to guarantee that only one translation runs at a time. This ensures that the continuation you mentioned only gets invoked once. It has to be done in some way like that because .translationTask supports running only one translation at a time.
Fixed an issue where tapping "Translate" after cancellation the previous translation would not work
Fixed an issue where cancellation would be reported in the UI
Improved translate as it now uses the detected source language, which is more reliable than it trying to detect it automatically from full HTML

I also opened the following issue: CMM-1107: Post translation in Reader sometimes breaks the HTML tags. I don't think there is an easy fix, so I'm not planning to address it in the scope of the PR.

I've tested a couple of posts in Mandarin, and it worked for me. Would you mind sharing a post for which the translation fails?

ScreenRecording_01-05-2026.18-11-50_1.MP4

crazytonyli · 2026-01-06T01:36:54Z

The translation works on my iPhone now. What do you think about adding a button to revert back to the original content?

crazytonyli

I still feel like the indirection between setting the configuration property to trigger the translation process and getting the translated result can be improved.

crazytonyli · 2026-01-06T01:56:53Z

WordPress/Classes/ViewRelated/Reader/Detail/ReaderDetailViewController.swift

+        guard #available(iOS 26, *) else {
+            return
+        }
+        let hostingController = UIHostingController(rootView: translationHostView)


It's annoying that the Translation framework does not support UIKit. What do you think about adding a comment here, saying this hidden UIHostingController view is used to present translation UI?

It definitely is. I added a note.

crazytonyli · 2026-01-06T02:12:25Z

Modules/Sources/WordPressIntelligence/UseCases/TranslationViewModel.swift

+        Color.clear
+            .frame(width: 0, height: 0)
+            .translationTask(viewModel.configuration) { session in
+                Task { @MainActor in


This Task is not needed.

I copied it from the documentation, but it looks like it's not actually needed. The closure is async. The await on MainActor confined ViewModel achieves the jump to the main thread. Updated.

sonarqubecloud · 2026-01-06T16:23:56Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kean added this to the 26.6 milestone Dec 22, 2025

kean added the Intelligence label Dec 22, 2025

Implement Reader Post translation

866bd15

kean force-pushed the task/integrate-translations branch from 8f8dc24 to 866bd15 Compare December 22, 2025 22:37

kean commented Dec 22, 2025

View reviewed changes

crazytonyli reviewed Jan 5, 2026

View reviewed changes

kean added 5 commits January 5, 2026 17:01

Add an assertion to check if translation is started

fb7f6a4

Add CancellationError support

df10676

Fix an issue with translation not restarted when cancelled

3283943

Add TranslationAvailability to improve language detection and ensure …

496e272

…it never restarts the translation if already started

Improve blur

2581508

kean requested a review from crazytonyli January 5, 2026 23:17

crazytonyli approved these changes Jan 6, 2026

View reviewed changes

kean added 2 commits January 6, 2026 11:18

Remove redundant Task

77adb04

Add comments

14cb490

Integrate Translation framework #25089

Are you sure you want to change the base?

Integrate Translation framework #25089

Conversation

kean commented Dec 22, 2025

Description

Testing instructions

Recording

Uh oh!

kean Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crazytonyli Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

crazytonyli Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

crazytonyli commented Jan 5, 2026

Uh oh!

kean commented Jan 5, 2026

Uh oh!

crazytonyli commented Jan 5, 2026

Uh oh!

kean commented Jan 5, 2026

Uh oh!

crazytonyli commented Jan 6, 2026

Uh oh!

crazytonyli left a comment

Choose a reason for hiding this comment

Uh oh!

crazytonyli Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

kean Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

crazytonyli Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

kean Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jan 6, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wpmobilebot commented Dec 22, 2025 •

edited

Loading

wpmobilebot commented Dec 22, 2025 •

edited

Loading