feat: convert lib/baseURL and API routes to TypeScript#58
Merged
mjdavidson merged 1 commit intomasterfrom May 7, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
5 files migrated server-side:
- lib/baseURL.js → lib/baseURL.ts (pure rename)
- pages/api/{admin-portal,sso,callback,magic-link}.js → .ts
Type-annotated handler signatures (NextApiRequest, NextApiResponse),
Organization type for the audit-log helper, narrowed catch errors via
`e instanceof Error`, and a runtime guard on req.query.code in the
callback (typed as string | string[] | undefined).
Picked up two latent SDK-v8 API renames that the .js code was getting
away with at runtime:
- clientID → clientId
- sso.getAuthorizationURL → sso.getAuthorizationUrl
Also dropped `domains: [...]` from createOrganization — v8's
CreateOrganizationOptions no longer accepts that field. The throwaway
demo org still works; visitors add domains through the Admin Portal UI
when needed.
Verified: typecheck (strict), lint, format:check, build all clean.
mjdavidson
force-pushed
the
mattd/explore-ts-server
branch
from
4c4e7a6 to
7ad383f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5 server-side files migrated:
lib/baseURL.tsand the 4pages/api/*routes.Picked up two latent SDK-v8 API renames the .js code was getting away with:
clientID→clientIdsso.getAuthorizationURL→sso.getAuthorizationUrlAlso dropped
domains: [...]fromcreateOrganization— v8'sCreateOrganizationOptionsno longer accepts it. The throwaway demo orgs still work; visitors add domains via the Admin Portal UI.