Skip to content

Conversation

@rarevalo13
Copy link

Description

Added the following connection types:

CleverOIDC
EntraIdOIDC
OktaOIDC

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

@rarevalo13 rarevalo13 requested a review from a team as a code owner November 20, 2025 17:23
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 20, 2025

Greptile Overview

Greptile Summary

Added three new OIDC connection types (CleverOIDC, EntraIdOIDC, OktaOIDC) to the ConnectionType enum to expand SSO provider support.

  • All three values added in correct alphabetical order
  • Minor style inconsistency: new types use OIDC (caps) while some existing types like AdpOidc and LoginGovOidc use Oidc (camelCase), though GenericOIDC already uses caps
  • No functional issues; changes are limited to enum definition

Confidence Score: 5/5

  • Safe to merge - simple enum additions with no logic changes
  • This is a straightforward addition of three enum values with no behavioral changes, proper alphabetical ordering, and no security concerns
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
src/sso/interfaces/connection-type.enum.ts 4/5 Added three new OIDC connection types in alphabetical order; minor casing inconsistency with existing enum values

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Enum as ConnectionType Enum
    participant SDK as WorkOS SDK
    participant API as WorkOS API

    Dev->>Enum: Add CleverOIDC, EntraIdOIDC, OktaOIDC
    Note over Enum: New connection types<br/>added to enum
    
    SDK->>Enum: Import ConnectionType
    SDK->>API: Send connection request<br/>with new type
    API-->>SDK: Handle new connection types
    SDK-->>Dev: Return connection response
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Auth0SAML = 'Auth0SAML',
AzureSAML = 'AzureSAML',
CasSAML = 'CasSAML',
CleverOIDC = 'CleverOIDC',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Inconsistent casing: this uses OIDC (all caps) while existing AdpOidc and LoginGovOidc use Oidc (camelCase). GenericOIDC uses caps, so there's already inconsistency in the codebase.

Prompt To Fix With AI
This is a comment left during a code review.
Path: src/sso/interfaces/connection-type.enum.ts
Line: 8:8

Comment:
**style:** Inconsistent casing: this uses `OIDC` (all caps) while existing `AdpOidc` and `LoginGovOidc` use `Oidc` (camelCase). `GenericOIDC` uses caps, so there's already inconsistency in the codebase.

How can I resolve this? If you propose a fix, please make it concise.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These casings match the API. Looks good

Auth0SAML = 'Auth0SAML',
AzureSAML = 'AzureSAML',
CasSAML = 'CasSAML',
CleverOIDC = 'CleverOIDC',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These casings match the API. Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants