Skip to content

fix: Fix incorrect url for listEffectivePermissionsByExternalId #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gjtorikian merged 1 commit into from
Apr 24, 2026
Merged

fix: Fix incorrect url for listEffectivePermissionsByExternalId #1574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/authorization/authorization.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2418,13 +2418,12 @@ describe('Authorization', () => {
const result =
await workos.authorization.listEffectivePermissionsByExternalId({
organizationMembershipId: testOrgMembershipId,
organizationId: testOrgId,
resourceTypeSlug: 'document',
externalId: 'doc-456',
});

expect(fetchURL()).toContain(
`/authorization/organizations/${testOrgId}/resources/document/doc-456/organization_memberships/${testOrgMembershipId}/permissions`,
`/authorization/organization_memberships/${testOrgMembershipId}/resources/document/doc-456/permissions`,
);
expect(result.object).toEqual('list');
expect(result.data).toHaveLength(2);
Expand Down Expand Up @@ -2453,7 +2452,6 @@ describe('Authorization', () => {

await workos.authorization.listEffectivePermissionsByExternalId({
organizationMembershipId: testOrgMembershipId,
organizationId: testOrgId,
resourceTypeSlug: 'document',
externalId: 'doc-456',
limit: 10,
Expand All @@ -2473,7 +2471,6 @@ describe('Authorization', () => {

await workos.authorization.listEffectivePermissionsByExternalId({
organizationMembershipId: testOrgMembershipId,
organizationId: testOrgId,
resourceTypeSlug: 'document',
externalId: 'doc-456',
before: 'perm_cursor789',
Expand All @@ -2491,7 +2488,6 @@ describe('Authorization', () => {

await workos.authorization.listEffectivePermissionsByExternalId({
organizationMembershipId: testOrgMembershipId,
organizationId: testOrgId,
resourceTypeSlug: 'document',
externalId: 'doc-456',
});
Expand Down
9 changes: 2 additions & 7 deletions src/authorization/authorization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,13 +1134,8 @@ export class Authorization {
async listEffectivePermissionsByExternalId(
options: ListEffectivePermissionsByExternalIdOptions,
): Promise<AutoPaginatable<Permission>> {
const {
organizationMembershipId,
organizationId,
resourceTypeSlug,
externalId,
} = options;
const endpoint = `/authorization/organizations/${organizationId}/resources/${resourceTypeSlug}/${externalId}/organization_memberships/${organizationMembershipId}/permissions`;
const { organizationMembershipId, resourceTypeSlug, externalId } = options;
const endpoint = `/authorization/organization_memberships/${organizationMembershipId}/resources/${resourceTypeSlug}/${externalId}/permissions`;
const serializedOptions = serializeListEffectivePermissionsOptions(options);
return new AutoPaginatable(
await fetchAndDeserialize<PermissionResponse, Permission>(
Expand Down
1 change: 0 additions & 1 deletion src/authorization/interfaces/list-effective-permissions-by-external-id-options.interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { PaginationOptions } from '../../common/interfaces/pagination-options.in

export interface ListEffectivePermissionsByExternalIdOptions extends PaginationOptions {
organizationMembershipId: string;
organizationId: string;
resourceTypeSlug: string;
externalId: string;
}
Loading