Skip to content

Start MySQL in the background while PHP is set up - #76

Merged
swissspidy merged 1 commit into
mainfrom
claude/quirky-goldberg-r1ssid
Oct 7, 2026
Merged

swissspidy merged 1 commit into
mainfrom
claude/quirky-goldberg-r1ssid

Conversation

@swissspidy

@swissspidy swissspidy commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Uses the new parallel step keywords so MySQL setup runs in the background (background: true) alongside Ghostscript, PHP and Composer setup, with a wait-all before "Prepare test database". wait-all rather than wait: setup-mysql, since the step is skipped on SQLite legs.

Companion to the same change in wp-cli/.github. The gain may be small (MySQL setup is often ~10s), so this is partly an experiment; compare job times against recent main runs.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XKUgMbWCUXHvDzgDBPWcZA


Generated by Claude Code

Summary by CodeRabbit

  • Chores
    • Improved automated test setup so MySQL initialization can run alongside other setup tasks, while ensuring it finishes before database preparation. SQLite test jobs continue without MySQL.

Use the new background/wait-all step keywords so the database server
download and start overlaps with the PHP and Composer setup.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XKUgMbWCUXHvDzgDBPWcZA
Copilot AI balanced review requested due to automatic review settings October 7, 2026 08:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 51dd0adc-2f72-4e77-9752-4b8ad700d988
📥 Commits

Reviewing files that changed from the base of the PR and between 8d3ce7e and ca91f03.

📒 Files selected for processing (1)
  • .github/workflows/reusable-testing.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The reusable testing workflow runs MySQL setup in the background for non-SQLite jobs. It waits for background work to finish before database preparation, including in SQLite jobs where MySQL setup is skipped.

Changes

Testing workflow

Layer / File(s) Summary
MySQL setup and synchronization
.github/workflows/reusable-testing.yml
MySQL setup runs as background work for non-SQLite jobs. A wait-all step waits before database preparation, including when the MySQL step is skipped.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to ca91f

MySQL setup is awaited before database preparation, and setup failures propagate. The documented behavior supports the SQLite path proceeding when MySQL setup is skipped; no actionable merge risk was established.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: running MySQL setup in the background while PHP is set up.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Member Author

package-command / WP trunk | PHP 8.5 | MySQL fails in the scenario Install from a remote zip URL that returns 404 (package-install.feature:1091). The local server returns HTTP 500 where the test expects 404.

This failure comes from main, not from this PR: last night's scheduled run on main (run 37549612948) fails the same scenario, along with the entity-command (--site_id typo warning) and media-command (<porcelain> error message) jobs. The failure is in package-command's test suite. No fix exists yet.

The change in this PR did work in that job: MySQL started in the background, the job waited for it before preparing the test database, and the other 394 of 395 Behat steps passed. I haven't re-run the job because it fails the same way on main, so a re-run would tell us nothing new.


Generated by Claude Code

@swissspidy
swissspidy merged commit 5b2dcbb into main Oct 7, 2026
141 of 156 checks passed
@swissspidy
swissspidy deleted the claude/quirky-goldberg-r1ssid branch October 7, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants