Repository navigation
Start MySQL in the background while PHP is set up - #76
Conversation
Use the new background/wait-all step keywords so the database server download and start overlaps with the PHP and Composer setup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XKUgMbWCUXHvDzgDBPWcZA
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe reusable testing workflow runs MySQL setup in the background for non-SQLite jobs. It waits for background work to finish before database preparation, including in SQLite jobs where MySQL setup is skipped. ChangesTesting workflow
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to MySQL setup is awaited before database preparation, and setup failures propagate. The documented behavior supports the SQLite path proceeding when MySQL setup is skipped; no actionable merge risk was established. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This failure comes from The change in this PR did work in that job: MySQL started in the background, the job waited for it before preparing the test database, and the other 394 of 395 Behat steps passed. I haven't re-run the job because it fails the same way on Generated by Claude Code |
Uses the new parallel step keywords so MySQL setup runs in the background (
background: true) alongside Ghostscript, PHP and Composer setup, with await-allbefore "Prepare test database".wait-allrather thanwait: setup-mysql, since the step is skipped on SQLite legs.Companion to the same change in wp-cli/.github. The gain may be small (MySQL setup is often ~10s), so this is partly an experiment; compare job times against recent
mainruns.🤖 Generated with Claude Code
https://claude.ai/code/session_01XKUgMbWCUXHvDzgDBPWcZA
Generated by Claude Code
Summary by CodeRabbit