-
Notifications
You must be signed in to change notification settings - Fork 69
Add wp db status command for database health overview
#307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
15
commits into
main
Choose a base branch
from
copilot/add-wp-db-status-command
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
970cf3f
Initial plan
Copilot 0a6e265
Add wp db status command implementation
Copilot 7c06ca3
Fix edge case handling for zero database size
Copilot 94d0fea
Update src/DB_Command.php
swissspidy ba35677
Update src/DB_Command.php
swissspidy 66478f6
Update src/DB_Command.php
swissspidy 8a0d032
Fix wp db status to accept parameters and run before WordPress loads
Copilot 9da36cf
Small fixes
swissspidy 10a1f72
Refactor status command for better maintainability and test robustness
Copilot d2e9c27
Merge branch 'main' into copilot/add-wp-db-status-command
swissspidy fa2545f
Merge branch 'main' into copilot/add-wp-db-status-command
swissspidy 13d3155
PHPStan fix
swissspidy 7992729
Refactor wp db status to work without loading WordPress
Copilot dc552dd
Fix escaping order for LIKE pattern in table prefix
Copilot 8dfc5d0
Merge branch 'main' into copilot/add-wp-db-status-command
swissspidy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,7 +50,8 @@ | |
| "db search", | ||
| "db tables", | ||
| "db size", | ||
| "db columns" | ||
| "db columns", | ||
| "db status" | ||
| ] | ||
| }, | ||
| "autoload": { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| Feature: Display database status overview | ||
|
|
||
| Scenario: Display database status for a WordPress install | ||
| Given a WP install | ||
|
|
||
| When I run `wp db status` | ||
| Then STDOUT should contain: | ||
| """ | ||
| Database Name: wp_cli_test | ||
| """ | ||
| And STDOUT should match /^Tables:\s+\d+$/m | ||
| And STDOUT should match /^Total Size:\s+[\d.]+ \wB$/m | ||
| And STDOUT should contain: | ||
| """ | ||
| Prefix: wp_ | ||
| """ | ||
| And STDOUT should match /^Engine:\s+\w+$/m | ||
| And STDOUT should match /^Charset:\s+\w+$/m | ||
| And STDOUT should match /^Collation:\s+\w+$/m | ||
| And STDOUT should contain: | ||
| """ | ||
| Check Status: OK | ||
| """ | ||
|
|
||
| Scenario: Run db status with MySQL defaults to check the database | ||
| Given a WP install | ||
|
|
||
| When I run `wp db status --defaults` | ||
| Then STDOUT should contain: | ||
| """ | ||
| Database Name: | ||
| """ | ||
| And STDOUT should contain: | ||
| """ | ||
| Check Status: OK | ||
| """ | ||
|
|
||
| Scenario: Run db status with --no-defaults to check the database | ||
| Given a WP install | ||
|
|
||
| When I run `wp db status --no-defaults` | ||
| Then STDOUT should contain: | ||
| """ | ||
| Database Name: | ||
| """ | ||
| And STDOUT should contain: | ||
| """ | ||
| Check Status: OK | ||
| """ | ||
|
|
||
| Scenario: Run db status with passed-in options | ||
| Given a WP install | ||
|
|
||
| When I run `wp db status --dbuser=wp_cli_test` | ||
| Then STDOUT should contain: | ||
| """ | ||
| Database Name: | ||
| """ | ||
| And STDOUT should contain: | ||
| """ | ||
| Check Status: OK | ||
| """ | ||
|
|
||
| When I run `wp db status --dbpass=password1` | ||
| Then STDOUT should contain: | ||
| """ | ||
| Database Name: | ||
| """ | ||
| And STDOUT should contain: | ||
| """ | ||
| Check Status: OK | ||
| """ | ||
|
|
||
| When I run `wp db status --dbuser=wp_cli_test --dbpass=password1` | ||
| Then STDOUT should contain: | ||
| """ | ||
| Database Name: | ||
| """ | ||
| And STDOUT should contain: | ||
| """ | ||
| Check Status: OK | ||
| """ | ||
swissspidy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| When I try `wp db status --dbuser=no_such_user` | ||
| Then the return code should not be 0 | ||
|
|
||
| When I try `wp db status --dbpass=no_such_pass` | ||
| Then the return code should not be 0 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.