Fix isort import-ordering in curvature.py#3568
Merged
Merged
Conversation
Group the local imports into a single parenthesized import from xrspatial.utils and order xrspatial.dataset_support before it, keeping the # local modules comment above the first local import. No behavioural change. Closes #3388
brendancol
commented
Jun 29, 2026
brendancol
left a comment
Contributor
Author
There was a problem hiding this comment.
PR Review: Fix isort import-ordering in curvature.py
Blockers (must fix before merge)
None.
Suggestions (should fix, not blocking)
None.
Nits (optional improvements)
None.
What looks good
- The diff is import-ordering only; no executable code path is touched.
- The set of imported names is unchanged from
main(10 names in, 10 out):dataset_support.supports_datasetplus the ninexrspatial.utilsnames.flake8reports no unused or missing imports, so nothing was dropped or orphaned in the collapse. # local modulesis kept above the first local import, matching the request in #3388 rather than isort's default of burying the comment between the two import lines.isort --check-onlyandflake8are both clean; existingtest_curvature.py(80 tests) passes.
Checklist
- No behavioural change (import-ordering only)
- Imported name set identical before/after
- isort clean
- flake8 clean
- Existing curvature tests pass
- New tests — not applicable (no behaviour change)
- README / docs — not applicable (no API change)
- Benchmark — not applicable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3388
isort --check-only xrspatial/curvature.pyfailed: the module had nineseparate
from xrspatial.utils import ...lines withxrspatial.dataset_supportordered after them.xrspatial.utilsimports into one parenthesized,alphabetically sorted import.
xrspatial.dataset_supportbeforexrspatial.utils, keeping the# local modulescomment above the first local import.Backends: not applicable (no code path touched).
Test plan:
isort --check-only xrspatial/curvature.pycleanflake8 xrspatial/curvature.pycleanpytest xrspatial/tests/test_curvature.py(80 passed)