Rename the addition terminology to indicator - #158
Merged
Conversation
"Addition" never described what the underline/circle actually is: the selection indicator, the term UIKit itself uses (for example UITabBar's selectionIndicatorImage). Rename the concept across the public options, the internal views, the tests, the example app, and the documentation. The old names are removed: - SwipeMenuViewOptions.TabView.Addition -> Indicator - SwipeMenuViewOptions.TabView.addition -> indicator - SwipeMenuViewOptions.TabView.AdditionView -> IndicatorView - SwipeMenuViewOptions.TabView.additionView -> indicatorView Internal TabView members follow (setupIndicatorView, moveIndicatorView, animateIndicatorView, and friends). The IndicatorView doc comments now describe each option precisely instead of the earlier broken English, and the changelog's unreleased entries reference the new spellings.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Clean, purely mechanical rename of "addition" → "indicator" terminology across the public API, internal implementation, tests, example app, and docs. Verified no leftover addition/Addition/additionView/AdditionView references remain in Sources/Tests/Example, and the CHANGELOG accurately reflects the net rename for the still-unreleased version. No logic changes, no bugs found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"Addition" never described what the underline/circle actually is: the selection indicator, the term UIKit itself uses (e.g.
UITabBar.selectionIndicatorImage). This PR renames the concept across the public options, the internal views, the tests, the example app, and the DocC documentation. The old names are removed (breaking change, recorded under Unreleased → Breaking):SwipeMenuViewOptions.TabView.AdditionIndicator(cases.underline/.circle/.noneunchanged)SwipeMenuViewOptions.TabView.additionindicatorSwipeMenuViewOptions.TabView.AdditionViewIndicatorViewSwipeMenuViewOptions.TabView.additionViewindicatorViewInternal
TabViewmembers follow the same vocabulary (setupIndicatorView,moveIndicatorView,animateIndicatorView, …), as do test helpers and test names.Also in this PR, since it is the terminology pass over these options:
IndicatorViewdoc comments now describe each option precisely (the old ones read e.g. "Underline height if addition style select.underline"); theCircle.cornerRadiuscomment no longer references a nonexistentheightproperty.additionalSafeAreaInsetsusages were explicitly protected from the rename (word-boundary matching) — no unrelated identifiers changed.Tests
--warnings-as-errors, which verifies no dangling symbol links remain.