Conversation
Validate Branch Name became blocking on this repository after #586, and it rejects two shapes that are not a naming-discipline problem. copilot/ and codex/ branches are named by a coding agent, not by the pull-request author, which is the same situation dependabot/ and renovate/ are already exempt for. And the trailing anchor rejected feature-478-repo-settings-audit, which carries the issue id and adds a descriptive slug. Allow both. The issue id stays mandatory for author-chosen branches, so decisions/0019 is unchanged in substance. Branch shapes with no issue id at all, such as code/ and fix/, remain rejected; admitting those would reverse the issue-linked naming the ADR decided, and belongs in an ADR amendment. Closes #590
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate Branch Namebecame a blocking required status check here after #586.Across the last 60 pull requests into this repository, 14 head branches match
the pattern and 46 do not. Two groups inside that 46 are not a naming
discipline problem, and this fixes both.
copilot/andcodex/joindependabot/andrenovate/in the always-allowed list. A coding agent picks those names, sorejecting them penalises something the pull-request author never chose.
app/copilot-swe-agentproducedcopilot/docs-adr-classify-zpmod,copilot/investigate-github-pages-ci, andcopilot/fix-metrics-job-failure.^(feature|bug|hotfix)-[1-9][0-9]*(-[a-z0-9]+)*$. The trailing anchor wasrejecting
feature-478-repo-settings-audit,feature-505-zsh-lint-reference-corpus,feature-509-generator-verifier-relocation, andfeature-513-promotion-trigger-policy, all of which carry the id.The issue id stays mandatory for author-chosen branches, so
decisions/0019-trunk-on-main-default.mdis unchanged in substance; it writesthe form as
feature-<id>and says nothing that forbids a suffix.Deliberately not included
Shapes carrying no issue id at all,
code/,fix/,feat/,docs/,ci/,chore/, andss-o-*, account for roughly 36 of the 46. Allowing them wouldreverse the issue-linked branch naming the ADR decided and that AGENTS.md
cites as enforced. If that is wanted it should be an ADR amendment argued on
its merits, not a widened regex. This means about 36 of the last 60 branch
names would still fail, so the naming habit does change.
Verification
A table over 18 branch names, covering both new allowances, the existing bot
prefixes,
next, and the shapes that must keep failing (code/*,fix/*,ss-o-*,feature-0,feature-,feature-505-,feature-505-Bad-Caps,bugfix-12). All 18 classify as intended.actionlintandtrunk checkareclean.
No persistent test is added. A test that restated the pattern would drift from
the workflow, and one that extracted it from the YAML needs its own script and
workflow wiring. Worth doing as follow-up, given this job already shipped one
silent-pass defect (#575), but out of scope here.
Closes #590