Skip to content

prune old string dtype class#3973

Open
d-v-b wants to merge 8 commits into
zarr-developers:mainfrom
d-v-b:prune-old-string-dtype
Open

prune old string dtype class#3973
d-v-b wants to merge 8 commits into
zarr-developers:mainfrom
d-v-b:prune-old-string-dtype

Conversation

@d-v-b
Copy link
Copy Markdown
Contributor

@d-v-b d-v-b commented May 14, 2026

When we supported NumPy versions < 2, we had to implement the variable-length string dtype on top of the numpy "object" dtype. For NumPy versions > 2, we use the StringDType.

Since we no longer support numpy < 2, we can remove the variable-length dtype class that used the "object" dtype. that's this PR.

@d-v-b d-v-b changed the title prune old string dtype prune old string dtype class May 14, 2026
@github-actions github-actions Bot added the needs release notes Automatically applied to PRs which haven't added release notes label May 14, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.34%. Comparing base (e815b51) to head (e4c3fda).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3973      +/-   ##
==========================================
+ Coverage   93.29%   93.34%   +0.05%     
==========================================
  Files          87       87              
  Lines       11752    11739      -13     
==========================================
- Hits        10964    10958       -6     
+ Misses        788      781       -7     
Files with missing lines Coverage Δ
src/zarr/core/dtype/npy/string.py 97.69% <100.00%> (+5.38%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot removed the needs release notes Automatically applied to PRs which haven't added release notes label May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant